From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master b342815: Improve define-function omitted-arg documentation Date: Fri, 27 May 2016 15:48:31 -0400 Message-ID: References: <20160527164722.20278.19217@vcs.savannah.gnu.org> <20160527164723.4A992220156@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1464378511 14769 80.91.229.3 (27 May 2016 19:48:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 27 May 2016 19:48:31 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 27 21:48:23 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b6Nk6-0004A0-Eh for ged-emacs-devel@m.gmane.org; Fri, 27 May 2016 21:48:22 +0200 Original-Received: from localhost ([::1]:47634 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6Nk5-0005B5-Kh for ged-emacs-devel@m.gmane.org; Fri, 27 May 2016 15:48:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6NjR-0005AL-6A for emacs-devel@gnu.org; Fri, 27 May 2016 15:47:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6NjK-0003IX-Rn for emacs-devel@gnu.org; Fri, 27 May 2016 15:47:41 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:41635) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6NjK-0003I7-K6 for emacs-devel@gnu.org; Fri, 27 May 2016 15:47:34 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1b6NjI-0003s1-Ty for emacs-devel@gnu.org; Fri, 27 May 2016 21:47:33 +0200 Original-Received: from modemcable043.43-19-135.mc.videotron.ca ([135.19.43.43]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 27 May 2016 21:47:32 +0200 Original-Received: from monnier by modemcable043.43-19-135.mc.videotron.ca with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 27 May 2016 21:47:32 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 25 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: modemcable043.43-19-135.mc.videotron.ca User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cancel-Lock: sha1:m6uoAnmPUrcshKkJerktg10VlG4= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204090 Archived-At: > -@defmac declare-function function file &optional arglist fileonly > +@defmac declare-function function file &rest args I'm OK with using &rest in the implementation, but it's probably best not to document this implementation choice in the manual. Similarly we should probably do something like the patch below. Stefan diff --git a/lisp/subr.el b/lisp/subr.el index 239bdc0..52e82e7 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -59,6 +59,8 @@ declare-function must be the first non-whitespace on a line. For more information, see Info node `(elisp)Declaring Functions'." + (declare (advertised-calling-convention + (fn file &optional arglist fileonly) nil)) ;; Does nothing - byte-compile-declare-function does the work. nil)