From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: master b342815: Improve define-function omitted-arg documentation
Date: Fri, 27 May 2016 15:48:31 -0400 [thread overview]
Message-ID: <jwva8jbthld.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 20160527164723.4A992220156@vcs.savannah.gnu.org
> -@defmac declare-function function file &optional arglist fileonly
> +@defmac declare-function function file &rest args
I'm OK with using &rest in the implementation, but it's probably best
not to document this implementation choice in the manual.
Similarly we should probably do something like the patch below.
Stefan
diff --git a/lisp/subr.el b/lisp/subr.el
index 239bdc0..52e82e7 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -59,6 +59,8 @@ declare-function
must be the first non-whitespace on a line.
For more information, see Info node `(elisp)Declaring Functions'."
+ (declare (advertised-calling-convention
+ (fn file &optional arglist fileonly) nil))
;; Does nothing - byte-compile-declare-function does the work.
nil)
next prev parent reply other threads:[~2016-05-27 19:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160527164722.20278.19217@vcs.savannah.gnu.org>
[not found] ` <20160527164723.4A992220156@vcs.savannah.gnu.org>
2016-05-27 16:58 ` master b342815: Improve define-function omitted-arg documentation Glenn Morris
2016-05-27 17:02 ` Glenn Morris
2016-05-27 17:52 ` Paul Eggert
2016-05-27 18:51 ` Eli Zaretskii
2016-05-27 19:48 ` Stefan Monnier [this message]
2016-05-28 1:19 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva8jbthld.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.