From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#23692: 25.1.50; Package.el gets confused if file has no autoloads (could be a bug in update-directory-autoloads) Date: Wed, 08 Jun 2016 21:47:04 -0400 Message-ID: References: <5751FEC2.5080807@live.com> <22y46lx4yq.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1465436906 7914 80.91.229.3 (9 Jun 2016 01:48:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 Jun 2016 01:48:26 +0000 (UTC) Cc: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel , 23692@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 09 03:48:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bAp4u-0006GD-Lf for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Jun 2016 03:48:12 +0200 Original-Received: from localhost ([::1]:60221 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAp4t-0006jL-RO for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Jun 2016 21:48:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAp4o-0006j5-7G for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2016 21:48:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAp4k-0002s5-8D for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2016 21:48:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49121) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAp4k-0002s0-4c for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2016 21:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bAp4j-0008QZ-QW for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2016 21:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jun 2016 01:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23692 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23692-submit@debbugs.gnu.org id=B23692.146543683132307 (code B ref 23692); Thu, 09 Jun 2016 01:48:01 +0000 Original-Received: (at 23692) by debbugs.gnu.org; 9 Jun 2016 01:47:11 +0000 Original-Received: from localhost ([127.0.0.1]:33225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAp3u-0008P1-T6 for submit@debbugs.gnu.org; Wed, 08 Jun 2016 21:47:11 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:40734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAp3t-0008Or-0a for 23692@debbugs.gnu.org; Wed, 08 Jun 2016 21:47:10 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u591l4FV024454; Wed, 8 Jun 2016 21:47:05 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 119A1AE600; Wed, 8 Jun 2016 21:47:05 -0400 (EDT) In-Reply-To: (Glenn Morris's message of "Mon, 06 Jun 2016 13:24:54 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5697=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5697> : inlines <4913> : streams <1648905> : uri <2226725> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119307 Archived-At: >>> When the a single-package file has no autoloads, the call to >>> update-directory-autoloads leaves the generated autoload files >>> modified, but unsaved. This causes package.el to prompt the user >>> about killing a modified file. Does the patch below fix the problem for you? Stefan diff --git a/lisp/emacs-lisp/autoload.el b/lisp/emacs-lisp/autoload.el index 6473e31..9cf96fd 100644 --- a/lisp/emacs-lisp/autoload.el +++ b/lisp/emacs-lisp/autoload.el @@ -1111,7 +1111,8 @@ write its autoloads into the specified file instead." ;; Don't modify the file if its content has not been changed, so `make' ;; dependencies don't trigger unnecessarily. - (when changed + (if (not changed) + (set-buffer-modified-p nil) (let ((version-control 'never)) (save-buffer)))