From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#24030: 25.0.95; mouse-drag-region regression Date: Sun, 24 Jul 2016 11:02:38 -0400 Message-ID: References: <87y44x2s7v.fsf@gmail.com> <83wpkgz83a.fsf@gnu.org> <871t2mw6el.fsf@gmail.com> <83twfgv76y.fsf@gnu.org> <83d1m4utkc.fsf@gnu.org> <83zip7t9a7.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1469372609 4026 80.91.229.3 (24 Jul 2016 15:03:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 Jul 2016 15:03:29 +0000 (UTC) Cc: 24030@debbugs.gnu.org, agrambot@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 24 17:03:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bRKvx-0006cu-NR for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Jul 2016 17:03:13 +0200 Original-Received: from localhost ([::1]:56299 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRKvw-0000WB-Os for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Jul 2016 11:03:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRKvp-0000W5-NO for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2016 11:03:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bRKvm-0000dI-Hn for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2016 11:03:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRKvm-0000dB-ET for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2016 11:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bRKvm-0006XR-2H for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2016 11:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Jul 2016 15:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24030 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24030-submit@debbugs.gnu.org id=B24030.146937256725113 (code B ref 24030); Sun, 24 Jul 2016 15:03:02 +0000 Original-Received: (at 24030) by debbugs.gnu.org; 24 Jul 2016 15:02:47 +0000 Original-Received: from localhost ([127.0.0.1]:35951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bRKvX-0006Wz-7t for submit@debbugs.gnu.org; Sun, 24 Jul 2016 11:02:47 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:40488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bRKvU-0006Wm-G0 for 24030@debbugs.gnu.org; Sun, 24 Jul 2016 11:02:45 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0BCFgA731xV/6SNCkxcgxCEAoVVwD6CTQQCAoE8PRABAQEBAQEBgQpBBYNdAQEEViMQCzQSFBgNJIg/zyMBAQEBAQEEAQEBAQEdizqBPQGDRweELQWzP4FFI4IXgX0igngBAQE X-IPAS-Result: A0BCFgA731xV/6SNCkxcgxCEAoVVwD6CTQQCAoE8PRABAQEBAQEBgQpBBYNdAQEEViMQCzQSFBgNJIg/zyMBAQEBAQEEAQEBAQEdizqBPQGDRweELQWzP4FFI4IXgX0igngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="249110729" Original-Received: from 76-10-141-164.dsl.teksavvy.com (HELO pastel.home) ([76.10.141.164]) by ironport2-out.teksavvy.com with ESMTP; 24 Jul 2016 11:02:38 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 57AB564CA6; Sun, 24 Jul 2016 11:02:38 -0400 (EDT) In-Reply-To: <83zip7t9a7.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 24 Jul 2016 17:12:16 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121484 Archived-At: > --- lisp/mouse.el~ 2016-07-20 09:52:16.559875700 +0300 > +++ lisp/mouse.el 2016-07-24 17:14:34.469052800 +0300 > @@ -815,14 +815,16 @@ The region will be defined with mark and > (setq mouse-selection-click-count-buffer (current-buffer)) > (deactivate-mark) > (let* ((scroll-margin 0) ; Avoid margin scrolling (Bug#9541). > + (start-posn (event-start start-event)) > + (start-point (posn-point start-posn)) > + (start-window (posn-window start-posn)) > + (_ (with-selected-window start-window > + (setq deactivate-mark nil))) > ;; We've recorded what we needed from the current buffer and > ;; window, now let's jump to the place of the event, where things > ;; are happening. > (_ (mouse-set-point start-event)) > (echo-keystrokes 0) > - (start-posn (event-start start-event)) > - (start-point (posn-point start-posn)) > - (start-window (posn-window start-posn)) > (bounds (window-edges start-window)) > (make-cursor-line-fully-visible nil) > (top (nth 1 bounds)) Looks fine to me, tho I don't think we should use with-selected-window here, but only with-current-buffer. Stefan