* Re: [Emacs-diffs] emacs-25 f785ff4: Clarify documentation of before/after-change-functions
[not found] ` <20160809165416.A7F9A220165@vcs.savannah.gnu.org>
@ 2016-08-09 17:59 ` Stefan Monnier
2016-08-09 18:18 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2016-08-09 17:59 UTC (permalink / raw)
To: emacs-devel; +Cc: Eli Zaretskii
> -This variable holds a list of functions to call before any buffer
> -modification. Each function gets two arguments, the beginning and end
> +This variable holds a list of functions to call before most buffer
> +modifications. Each function gets two arguments, the beginning and end
This looks wrong. It should be called before *every* modification.
syntax-ppss relies on this property, for example.
And I can't think of any reason why we couldn't preserve that property.
In which case is it not run?
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] emacs-25 f785ff4: Clarify documentation of before/after-change-functions
2016-08-09 17:59 ` [Emacs-diffs] emacs-25 f785ff4: Clarify documentation of before/after-change-functions Stefan Monnier
@ 2016-08-09 18:18 ` Eli Zaretskii
2016-08-09 19:02 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2016-08-09 18:18 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Tue, 09 Aug 2016 13:59:25 -0400
>
> > -This variable holds a list of functions to call before any buffer
> > -modification. Each function gets two arguments, the beginning and end
> > +This variable holds a list of functions to call before most buffer
> > +modifications. Each function gets two arguments, the beginning and end
>
> This looks wrong. It should be called before *every* modification.
> syntax-ppss relies on this property, for example.
> And I can't think of any reason why we couldn't preserve that property.
>
> In which case is it not run?
In some cases when we delete text. And a few special cases you can
see in coding.c.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] emacs-25 f785ff4: Clarify documentation of before/after-change-functions
2016-08-09 18:18 ` Eli Zaretskii
@ 2016-08-09 19:02 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2016-08-09 19:02 UTC (permalink / raw)
To: emacs-devel
>> In which case is it not run?
> In some cases when we delete text. And a few special cases you can
> see in coding.c.
We should fix them, rather the documentation.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-09 19:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160809165416.24861.65995@vcs.savannah.gnu.org>
[not found] ` <20160809165416.A7F9A220165@vcs.savannah.gnu.org>
2016-08-09 17:59 ` [Emacs-diffs] emacs-25 f785ff4: Clarify documentation of before/after-change-functions Stefan Monnier
2016-08-09 18:18 ` Eli Zaretskii
2016-08-09 19:02 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.