From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master f57c710: Use a named function for global minor mode turn-on argument Date: Mon, 24 Jul 2017 10:33:42 -0400 Message-ID: References: <20170723194435.31877.401@vcs0.savannah.gnu.org> <20170723194436.81A9D20DDA@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1500907278 6618 195.159.176.226 (24 Jul 2017 14:41:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Jul 2017 14:41:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Mark Oteiza To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 24 16:41:14 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZeXn-0001QN-Ne for ged-emacs-devel@m.gmane.org; Mon, 24 Jul 2017 16:41:11 +0200 Original-Received: from localhost ([::1]:55221 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZeXt-0007mR-7e for ged-emacs-devel@m.gmane.org; Mon, 24 Jul 2017 10:41:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZeQd-0002bG-8T for emacs-devel@gnu.org; Mon, 24 Jul 2017 10:33:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZeQa-0008L3-L6 for emacs-devel@gnu.org; Mon, 24 Jul 2017 10:33:47 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:52636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZeQa-0008In-Fr for emacs-devel@gnu.org; Mon, 24 Jul 2017 10:33:44 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v6OEXgYS015231; Mon, 24 Jul 2017 10:33:42 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 162C166154; Mon, 24 Jul 2017 10:33:42 -0400 (EDT) In-Reply-To: <20170723194436.81A9D20DDA@vcs0.savannah.gnu.org> (Mark Oteiza's message of "Sun, 23 Jul 2017 15:44:36 -0400 (EDT)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6078=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6078> : inlines <5991> : streams <1755574> : uri <2468914> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216964 Archived-At: > ;;;###autoload > +(defun turn-on-display-line-numbers-mode () > + "Turn on `display-line-numbers-mode'." > + (unless (or (minibufferp) > + ;; taken from linum.el > + (and (daemonp) (null (frame-parameter nil 'client)))) > + (display-line-numbers-mode))) Could you make it use the "display-line-numbers-" prefix? Stefan "who'd also use a =A8--" since it's unlikely to be useful outside of the package"