From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#30823: 25.3; modification-hooks of overlays are not run in some cases Date: Sun, 19 Aug 2018 16:46:09 -0400 Message-ID: References: <83lgetri7r.fsf@gnu.org> <87in9cpd3a.fsf@gmail.com> <87in48ww9l.fsf@gmail.com> <83o9e0f9uj.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1534711509 12300 195.159.176.226 (19 Aug 2018 20:45:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 19 Aug 2018 20:45:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: victorhge@gmail.com, Noam Postavsky , 30823@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 19 22:45:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frUZL-00030j-6b for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Aug 2018 22:45:03 +0200 Original-Received: from localhost ([::1]:44070 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frUbR-0000SC-Kf for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Aug 2018 16:47:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frUbL-0000Ru-AM for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 16:47:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frUbG-0001n4-Bz for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 16:47:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49823) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1frUbG-0001n0-8W for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 16:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1frUbG-0002Tu-3L for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 16:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Aug 2018 20:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30823-submit@debbugs.gnu.org id=B30823.15347115799481 (code B ref 30823); Sun, 19 Aug 2018 20:47:02 +0000 Original-Received: (at 30823) by debbugs.gnu.org; 19 Aug 2018 20:46:19 +0000 Original-Received: from localhost ([127.0.0.1]:54841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frUaZ-0002Sr-7G for submit@debbugs.gnu.org; Sun, 19 Aug 2018 16:46:19 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:49985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frUaV-0002Sh-QX for 30823@debbugs.gnu.org; Sun, 19 Aug 2018 16:46:16 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w7JKkA18001834; Sun, 19 Aug 2018 16:46:11 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id E28E8AE1ED; Sun, 19 Aug 2018 16:46:09 -0400 (EDT) In-Reply-To: <83o9e0f9uj.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Aug 2018 09:49:08 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.1 X-NAI-Spam-Rules: 3 Rules triggered TRK_NCM1=0.1, EDT_SA_DN_PASS=0, RV6354=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6354> : inlines <6821> : streams <1795977> : uri <2691919> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149600 Archived-At: >> Coming back to this, there is also the possibility of passing true for >> PREPARE, though I'm not sure if that would be better or worse. Any >> comments? > AFAIR, we never want to use PREPARE = true when dealing with the > *Messages* buffer, you can see that elsewhere in message_dolog. The > reason I believe is that we might trigger infinite recursion if the > modification hooks log a message for some reason. The current code already allows running `message` in this way (and that leads to suboptimal behavior, tho nothing really serious). I think we should use `true` here and then actively try and detect nested uses of `message` and deal with those in an ad-hoc way (e.g. bind inhibit-modification-hooks during the nested call so the recursion is at most 2 deep). The benefit is that it makes this part of the code more "normal" and will probably fix/avoid other bugs like this one. The patch I sent in https://lists.gnu.org/archive/html/emacs-devel/2018-05/msg00600.html went in this direction and my experimentation with it did not encounter any serious problem. IOW I think the comment near message_dolog is largely out of date. Stefan