Re: [elpa] master 61ad720: packages/nadvice: Fix advice-remove behaviour

Re: [elpa] master 61ad720: packages/nadvice: Fix advice-remove behaviour

[Stefan Monnier]

>  ;;;###autoload
>  (defun advice-remove (symbol function)
> -  (ad-remove-advice symbol 'around function)
> -  (ad-activate symbol))
> +  ;; Just return nil if there is no advice, rather than signaling an
> +  ;; error.
> +  (condition-case nil
> +      (ad-remove-advice symbol 'around function)
> +    (error nil))
> +  (condition-case nil
> +      (ad-activate symbol)
> +    (error nil)))

Thanks, looks good'nuf


        Stefan

Re: [elpa] master 61ad720: packages/nadvice: Fix advice-remove behaviour

[Michael Albinus]

>  ;;;###autoload
>  (defun advice-remove (symbol function)
> -  (ad-remove-advice symbol 'around function)
> -  (ad-activate symbol))
> +  ;; Just return nil if there is no advice, rather than signaling an
> +  ;; error.
> +  (condition-case nil
> +      (ad-remove-advice symbol 'around function)
> +    (error nil))
> +  (condition-case nil
> +      (ad-activate symbol)
> +    (error nil)))

I would write

(ignore-errors (ad-remove-advice symbol 'around function))
(ignore-errors (ad-activate symbol))

Best regards, Michael.

Re: [elpa] master 61ad720: packages/nadvice: Fix advice-remove behaviour

[Stefan Monnier]

> +  ;; Just return nil if there is no advice, rather than signaling an
> +  ;; error.
> +  (condition-case nil
> +      (ad-remove-advice symbol 'around function)
> +    (error nil))
> +  (condition-case nil
> +      (ad-activate symbol)
> +    (error nil)))

BTW, I just pushed a change which adds support for advice-member-p and
changes the above code to make use of it, in order to silence
fewer errors.

It works in my tests, but could you check that it still works for you?


        Stefan

Re: [elpa] master 61ad720: packages/nadvice: Fix advice-remove behaviour

[Thomas Fitzsimmons]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> +  ;; Just return nil if there is no advice, rather than signaling an
>> +  ;; error.
>> +  (condition-case nil
>> +      (ad-remove-advice symbol 'around function)
>> +    (error nil))
>> +  (condition-case nil
>> +      (ad-activate symbol)
>> +    (error nil)))
>
> BTW, I just pushed a change which adds support for advice-member-p and
> changes the above code to make use of it, in order to silence
> fewer errors.
>
> It works in my tests, but could you check that it still works for you?

Confirmed still working, thanks.

Thomas