From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Alex Branham <alex.branham@gmail.com>, 33170-done@debbugs.gnu.org
Subject: bug#33170: 27.0.50; interactive spec with cl-defgeneric/method
Date: Tue, 30 Oct 2018 08:48:49 -0400 [thread overview]
Message-ID: <jwva7mvk3co.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <838t2floza.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 30 Oct 2018 12:15:37 +0200")
>> Thanks for the response. Seems like the two-function solution is the way
>> to go I guess. I do think this should be documented as a limitation
>> somewhere though.
> Done.
Should we add a warning for it?
Stefan
diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el
index fb4f3ab680..025653de70 100644
--- a/lisp/emacs-lisp/cl-generic.el
+++ b/lisp/emacs-lisp/cl-generic.el
@@ -355,6 +355,9 @@ cl-generic-define-context-rewriter
. ,(lambda () spec-args))
macroexpand-all-environment)))
(require 'cl-lib) ;Needed to expand `cl-flet' and `cl-function'.
+ (when (interactive-form (cadr fun))
+ (message "Interactive forms unsupported in generic functions: %S"
+ (interactive-form (cadr fun))))
;; First macroexpand away the cl-function stuff (e.g. &key and
;; destructuring args, `declare' and whatnot).
(pcase (macroexpand fun macroenv)
next prev parent reply other threads:[~2018-10-30 12:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 22:19 bug#33170: 27.0.50; interactive spec with cl-defgeneric/method Alex Branham
2018-10-27 6:54 ` Eli Zaretskii
2018-10-27 12:40 ` Alex Branham
2018-10-27 14:47 ` Eli Zaretskii
2018-10-27 14:50 ` Alex Branham
2018-10-27 16:11 ` Eli Zaretskii
2018-10-27 16:14 ` Alex Branham
2018-10-27 21:49 ` Stefan Monnier
2018-10-29 14:18 ` Alex Branham
2018-10-30 10:15 ` Eli Zaretskii
2018-10-30 12:48 ` Stefan Monnier [this message]
2018-10-30 13:09 ` Eli Zaretskii
2018-10-31 14:49 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva7mvk3co.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=33170-done@debbugs.gnu.org \
--cc=alex.branham@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.