From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/so-long d216f81: fixup! Add so-long library Date: Sun, 14 Apr 2019 11:03:16 -0400 Message-ID: References: <20190414125501.16807.79719@vcs0.savannah.gnu.org> <20190414125502.AB90320536@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="218048"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Phil Sainty To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 14 17:04:07 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hFgft-000uaF-Su for ged-emacs-devel@m.gmane.org; Sun, 14 Apr 2019 17:04:06 +0200 Original-Received: from localhost ([127.0.0.1]:36649 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFgfs-0006Ba-UP for ged-emacs-devel@m.gmane.org; Sun, 14 Apr 2019 11:04:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFgfA-0006B0-76 for emacs-devel@gnu.org; Sun, 14 Apr 2019 11:03:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hFgf9-0003zV-Ba for emacs-devel@gnu.org; Sun, 14 Apr 2019 11:03:20 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:38766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFgf9-0003xg-3p for emacs-devel@gnu.org; Sun, 14 Apr 2019 11:03:19 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x3EF3HlS009373; Sun, 14 Apr 2019 11:03:17 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 007B96A134; Sun, 14 Apr 2019 11:03:16 -0400 (EDT) In-Reply-To: <20190414125502.AB90320536@vcs0.savannah.gnu.org> (Phil's message of "Sun, 14 Apr 2019 08:55:02 -0400 (EDT)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6524=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6524> : inlines <7052> : streams <1818644> : uri <2831966> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235443 Archived-At: > +(defun turn-on-so-long-minor-mode () > + "Enable minor mode `so-long-minor-mode'." > + (so-long-minor-mode 1)) You don't need to pass `1`, so you could also write: (defalias 'turn-on-so-long-minor-mode #'so-long-minor-mode) or just don't define turn-on-so-long-minor-mode at all, which is what I recommend. > +(defun turn-off-so-long-minor-mode () > + "Disable minor mode `so-long-minor-mode'." > + (so-long-minor-mode -1)) I also recommend not to bother defining the turn-off function and let users call (so-long-minor-mode -1) for the few cases where they might need it. Stefan