From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 35381@debbugs.gnu.org
Subject: bug#35381: 26.2; nxml-mode doesn't fontify attributes in single quotes
Date: Wed, 24 Apr 2019 10:52:01 -0400 [thread overview]
Message-ID: <jwva7gfqx6a.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87v9z4qjit.fsf@gmail.com> (Noam Postavsky's message of "Tue, 23 Apr 2019 21:28:10 -0400")
> Well, I was pretty sure that XML allows both quotes, but just to make
> things definitive, https://www.w3.org/TR/xml/#NT-AttValue:
>
> [10] AttValue ::= '"' ([^<&"] | Reference)* '"'
> | "'" ([^<&'] | Reference)* "'"
Thanks for checking.
> I didn't actually checkout and compile before+after, but I'm pretty sure
> it's [56e1097584], same as Bug#32003.
>
> [56e1097584]: 2016-01-16 15:03:42 -0500
> lisp/nxml: Use syntax-tables for comments
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=56e1097584c13f2b6db85592769db1c6c36e9419
Ah, yes, that makes sense.
> s/more/equally/, but otherwise yes. Patching sgml-mode is shorter and
> even fixes Bug#8203 as well. Still good for emacs-26 I hope, since this
> is for an (nxml-mode) regression in 26.1.
Great, thanks.
> --- a/lisp/textmodes/sgml-mode.el
> +++ b/lisp/textmodes/sgml-mode.el
> @@ -103,7 +103,7 @@ (defcustom sgml-mode-hook nil
> ;; As long as Emacs's syntax can't be complemented with predicates to context
> ;; sensitively confirm the syntax of characters, we have to live with this
> ;; kludgy kind of tradeoff.
> -(defvar sgml-specials '(?\")
> +(defvar sgml-specials '(?\" ?\')
> "List of characters that have a special meaning for SGML mode.
> This list is used when first loading the `sgml-mode' library.
> The supported characters and potential disadvantages are:
I think this "disadvantages" part of the docstring is out of date.
Can you update it while you're at it?
Also, we probably want to mark this var as obsolete.
Stefan
next prev parent reply other threads:[~2019-04-24 14:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 16:08 bug#35381: 26.2; nxml-mode doesn't fontify attributes in single quotes Noam Postavsky
2019-04-23 16:09 ` Stefan Monnier
2019-04-24 1:28 ` Noam Postavsky
2019-04-24 14:52 ` Stefan Monnier [this message]
2019-04-25 2:24 ` Noam Postavsky
2019-04-25 12:47 ` Stefan Monnier
2019-04-26 11:32 ` Noam Postavsky
2019-04-29 21:23 ` Stefan Monnier
2019-05-05 3:52 ` Noam Postavsky
2019-05-05 13:06 ` Stefan Monnier
2019-05-05 13:49 ` Noam Postavsky
2019-05-05 14:20 ` martin rudalics
2019-05-05 14:36 ` Noam Postavsky
2019-05-09 11:45 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva7gfqx6a.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=35381@debbugs.gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.