From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 83c3a61: lisp/gnus/message.el (message-send-mail): Don't wrongly assert on Unicode msg Date: Tue, 04 Jun 2019 09:15:31 -0400 Message-ID: References: <20190603135626.32064.50250@vcs0.savannah.gnu.org> <20190603135628.1D13220AD1@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="77270"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel To: Oleh Krehel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 04 15:16:03 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hY9IG-000Juq-Ci for ged-emacs-devel@m.gmane.org; Tue, 04 Jun 2019 15:16:00 +0200 Original-Received: from localhost ([127.0.0.1]:52526 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hY9IF-0008Tb-8U for ged-emacs-devel@m.gmane.org; Tue, 04 Jun 2019 09:15:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hY9Hz-0008TF-SU for emacs-devel@gnu.org; Tue, 04 Jun 2019 09:15:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hY9Hy-0002Qq-6S for emacs-devel@gnu.org; Tue, 04 Jun 2019 09:15:43 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:22990) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hY9Hu-0002G0-9x for emacs-devel@gnu.org; Tue, 04 Jun 2019 09:15:40 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7A2EF811DE; Tue, 4 Jun 2019 09:15:34 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5061680B5D; Tue, 4 Jun 2019 09:15:33 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1559654133; bh=5XPR1PCeFpv6zI68sBJ3YEzq3uVR0X1dTp3oY94Q3Gg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=M89YNfIJ1q6jHDW7Pt0STmvQl7l/QF/QzXt1N1FNOavHSlKnao9SuoEQyotd2dyN7 RfRgYMZGjHZK5M+fRDVm6KuRm/exWNr56iEANX2QHBJUi91UY+ZkiNnVJC3/nC8fke ZP+bWWvlMgUBk1NzuXu5MAOqx6s9Z4eWOeYhYDJkmXBUJLxapxjH+TzbjiYYszL4oi +7L0pvFdpTCbFI6E4D+YzbpqBEbU+HK91hdTXXfjuTVjustS1ZnYo+vfvnXb34I9im R2Nyi4q+moXhRy1sLbyuaUshi9iopye9KZuhhsSXdkE1hdjR3/KMyDqV12q+fskwDd aYxS3HQIgJMuQ== Original-Received: from pastel (unknown [45.72.167.35]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D5F991203A2; Tue, 4 Jun 2019 09:15:32 -0400 (EDT) In-Reply-To: (Oleh Krehel's message of "Tue, 4 Jun 2019 11:00:28 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237246 Archived-At: > There's already existing message.el code that sets > `message-inhibit-body-encoding' to t. But if the encoding is > inhibited, we should not assert if Unicode was not encoded. So from your description I think indeed this has nothing to do with Unicode: the code you changed doesn't "assert if Unicode was not encoded". It asserts that the text was not encoded. Unicode or anything else. German umlauts are chars that indeed appear in the Unicode charset, but they also appear in many other charsets (such as latin1). "Encoding" turns chars into bytes and the test verifies that there are only bytes left. Stefan