From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: `message' not outputting the newline "atomically" Date: Sun, 23 Jun 2019 08:53:48 -0400 Message-ID: References: <83y31xr3aa.fsf@gnu.org> <26154872-1a5c-7302-0f32-b16aff8e0ae7@cs.ucla.edu> <83blytq90m.fsf@gnu.org> <95de57fb-ef8c-a65f-d3ca-4a9e7f0f38bc@cs.ucla.edu> <83a7ecquzb.fsf@gnu.org> <83tvckp5ni.fsf@gnu.org> <83r27op1wb.fsf@gnu.org> <60d1b05d-ef4c-252a-0626-8c69c103fdf0@cs.ucla.edu> <83o92rpk1g.fsf@gnu.org> <9d07a8e2-7f9b-bbfa-b73e-0d7aee09b099@cs.ucla.edu> <83zhmankgu.fsf@gnu.org> <31b12a41-18f2-d20c-55dc-28f7adb8606c@cs.ucla.edu> <83y31tm40j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="233798"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 23 14:54:11 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hf20Z-000yhf-4J for ged-emacs-devel@m.gmane.org; Sun, 23 Jun 2019 14:54:11 +0200 Original-Received: from localhost ([::1]:44658 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hf20X-0005Gn-Pq for ged-emacs-devel@m.gmane.org; Sun, 23 Jun 2019 08:54:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47753) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hf20R-0005F5-Tc for emacs-devel@gnu.org; Sun, 23 Jun 2019 08:54:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hf20Q-0004GO-17 for emacs-devel@gnu.org; Sun, 23 Jun 2019 08:54:03 -0400 Original-Received: from [195.159.176.226] (port=42820 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hf20P-0004E7-Qa for emacs-devel@gnu.org; Sun, 23 Jun 2019 08:54:01 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hf20I-000yQs-0O for emacs-devel@gnu.org; Sun, 23 Jun 2019 14:53:54 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:r5pMFd3vcjbO6Raayo9NeVPBUGY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238058 Archived-At: > What if Emacs crashes half way through that loop, because 'i' is > computed incorrectly? With line buffering, we risk not seeing > anything. Seeing none of the 32 bytes of fingerprint instead of only seeing the first N of them seems like a very minor inconvenient. Buffering can indeed be harmful, but only when significant computation/time can pass between the `fprintf` and the moment the corresponding text is "displayed", which is not the case here (nor anywhere else in Emacs's C code, according to my quick "grep stderr"). > So this looks like a net loss to me. I don't have a strong opinion on this, but FWIW, I see a net gain and no significant loss. Stefan