From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 0528a7c: Ensure that expand-file-name returns an absolute file name Date: Tue, 09 Jul 2019 11:25:50 -0400 Message-ID: References: <20190708223951.10291.7621@vcs0.savannah.gnu.org> <20190708223953.3172920BD5@vcs0.savannah.gnu.org> <83tvbw5408.fsf@gnu.org> <83sgrf5kj2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="48201"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: kbrown@cornell.edu, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 09 17:32:06 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hks69-000CKS-KN for ged-emacs-devel@m.gmane.org; Tue, 09 Jul 2019 17:32:05 +0200 Original-Received: from localhost ([::1]:51106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hks4p-00046R-DG for ged-emacs-devel@m.gmane.org; Tue, 09 Jul 2019 11:30:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44517) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hks0E-0006eE-9z for emacs-devel@gnu.org; Tue, 09 Jul 2019 11:25:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hks0D-0000vR-AN for emacs-devel@gnu.org; Tue, 09 Jul 2019 11:25:58 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43455) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hks0A-0000tS-9c; Tue, 09 Jul 2019 11:25:54 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A6CA11008A7; Tue, 9 Jul 2019 11:25:52 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 717D910067D; Tue, 9 Jul 2019 11:25:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1562685951; bh=GcOo3UNtSDVBVqlwSEmdy9+gpspgRbwSVkovlfTx6sA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=og4h1O3Rv9FyB6DYUgyNARHPvk/Kg8IlezlaXuEQmjR9n8+mluD4x5y1zB6jzjZbN AoN1/6CN9EmiMa3pDstdwrP+t/qumRV4PVwyxaGWB8CHwbfgQq1d4RzYzBfxFeILBp ziBtGrLkIy7sN0B6JJ88lyN0t0qREAYLxJigwhZkjm+NK3MdrkGIMUd/u0mGT5wDyy WtgkQJrDYtwE51lAUUjDmCpN+kkIQM38MlHV3EUUHFbr2pC1DSFeHJvcS+5e7mt+yi Lg84zvF+0AbeSNqpfdGMaK6Jp4Rmg40Eval+ACixLNf76fR27khRWK/c0VJ1XJt4ai Qd2zd0ep+3tdA== Original-Received: from alfajor (76-10-138-228.dsl.teksavvy.com [76.10.138.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 349C3120BFC; Tue, 9 Jul 2019 11:25:51 -0400 (EDT) In-Reply-To: <83sgrf5kj2.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Jul 2019 17:50:57 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238449 Archived-At: > It isn't entirely arbitrary. I'd have gone with "/", but I also consider that as arbitrary: I don't think there can be a non-arbitrary choice here, other than signaling an error because we don't have any information that can give us a hint about what was the intended absolute directory. > I think expand-file-name should try to avoid signaling an error as > much as possible, because it is called by many primitives and core > functions. If we signal an error, we risk getting the users into a > situation where they cannot even shut down Emacs, let alone do > something less trivial. A relative default-directory is something extremely rare, so if some operations like C-x C-c fail in that case I wouldn't mind. Stefan