* Re: [Emacs-diffs] master 783eca5: Make describe-face also output the version information
[not found] ` <20190714165036.218A32088F@vcs0.savannah.gnu.org>
@ 2019-07-15 13:20 ` Stefan Monnier
2019-07-15 16:01 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2019-07-15 13:20 UTC (permalink / raw)
To: emacs-devel; +Cc: Lars Ingebrigtsen
> - (terpri)))))))
> + (terpri)
> + (let ((version-info (describe-variable-custom-version-info
> + f 'face)))
> + (when version-info
> + (insert version-info)
> + (terpri)))))))))
Any chance you could do it like I did for vars and functions (i.e. via
a help-fns-describe-face-functions)?
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Emacs-diffs] master 783eca5: Make describe-face also output the version information
2019-07-15 13:20 ` [Emacs-diffs] master 783eca5: Make describe-face also output the version information Stefan Monnier
@ 2019-07-15 16:01 ` Lars Ingebrigtsen
2019-07-15 19:36 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-15 16:01 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> - (terpri)))))))
>> + (terpri)
>> + (let ((version-info (describe-variable-custom-version-info
>> + f 'face)))
>> + (when version-info
>> + (insert version-info)
>> + (terpri)))))))))
>
> Any chance you could do it like I did for vars and functions (i.e. via
> a help-fns-describe-face-functions)?
Sure; looks easy enough. I think I'll report this as a separate bug,
though, since I probably won't have time the next few days.
By the way, looking over the new infrastructure, perhaps these two bits
should be separated out into separate functions for
help-fns-describe-variable-functions?
They're currently in describe-variable:
;; Make a link to customize if this variable can be customized.
(when (custom-variable-p variable)
(let ((customize-label "customize"))
(terpri)
(terpri)
(princ (concat "You can " customize-label " this variable."))
(with-current-buffer standard-output
(save-excursion
(re-search-backward
(concat "\\(" customize-label "\\)") nil t)
(help-xref-button 1 'help-customize-variable variable))))
;; Note variable's version or package version.
(let ((output (describe-variable-custom-version-info variable)))
(when output
(terpri)
(terpri)
(princ output))))
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Emacs-diffs] master 783eca5: Make describe-face also output the version information
2019-07-15 16:01 ` Lars Ingebrigtsen
@ 2019-07-15 19:36 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2019-07-15 19:36 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
> By the way, looking over the new infrastructure, perhaps these two bits
> should be separated out into separate functions for
> help-fns-describe-variable-functions?
>
> They're currently in describe-variable:
>
> ;; Make a link to customize if this variable can be customized.
> (when (custom-variable-p variable)
> (let ((customize-label "customize"))
> (terpri)
> (terpri)
> (princ (concat "You can " customize-label " this variable."))
> (with-current-buffer standard-output
> (save-excursion
> (re-search-backward
> (concat "\\(" customize-label "\\)") nil t)
> (help-xref-button 1 'help-customize-variable variable))))
> ;; Note variable's version or package version.
> (let ((output (describe-variable-custom-version-info variable)))
> (when output
> (terpri)
> (terpri)
> (princ output))))
Indeed,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-15 19:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190714165035.21690.67881@vcs0.savannah.gnu.org>
[not found] ` <20190714165036.218A32088F@vcs0.savannah.gnu.org>
2019-07-15 13:20 ` [Emacs-diffs] master 783eca5: Make describe-face also output the version information Stefan Monnier
2019-07-15 16:01 ` Lars Ingebrigtsen
2019-07-15 19:36 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.