From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: arm-mode Date: Mon, 19 Aug 2019 16:53:15 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="81153"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: "rms@gnu.org" , "emacs-devel@gnu.org" To: Charles Jackson Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 19 22:54:17 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hzofQ-000KwX-If for ged-emacs-devel@m.gmane.org; Mon, 19 Aug 2019 22:54:16 +0200 Original-Received: from localhost ([::1]:57724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzofO-0001sQ-8a for ged-emacs-devel@m.gmane.org; Mon, 19 Aug 2019 16:54:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51444) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzoea-0001qx-13 for emacs-devel@gnu.org; Mon, 19 Aug 2019 16:53:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzoeY-0001zJ-Hr for emacs-devel@gnu.org; Mon, 19 Aug 2019 16:53:23 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:32531) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hzoeY-0001yL-BU; Mon, 19 Aug 2019 16:53:22 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A6831446918; Mon, 19 Aug 2019 16:53:20 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 88A88446914; Mon, 19 Aug 2019 16:53:19 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1566247999; bh=xUV38DhdTWMg30SJ8VbTPnFCC2RSCiNb05ptKpY48fA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=pGDdceI0geaxFekk/1Ms3/oke2lRkdX6FEayCKYo6U/Zc55mimklRdNZZmglXEshS vthZ0pa04S27FIpZKGzle8pu20sBGTKIbrQuLXCm0OvbcqGTaTbZFPLfSITM6J8DcM gxzsl65wH23wfeKXA2Pd6PoBe42IYwtFnrkxqocP5G6NU/gxGwGT7vs07UWHJqRXrc gwhRHSkrmN1DehM1y/AKOFoe2zaKZzmx0PwTTVv1qLuZw68jyBXNYoDZTEm7xmUwXz OuCSqa/qvxE63r3SIJKy7lJD+4gfwrtH46fHH5zc8S2jtOxGSHgK9276zhGsDFaRiO f04WJKH7bZKWw== Original-Received: from alfajor (unknown [46.189.28.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BFBD7120320; Mon, 19 Aug 2019 16:53:18 -0400 (EDT) In-Reply-To: (Charles Jackson's message of "Sun, 18 Aug 2019 06:12:27 +0000") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239468 Archived-At: > Thank you for the code review Stefan. I have implemented most of the > fixed you suggested. Following is what I have a few questions about. > > I need that M-; key binding because a /* */ style comment should be > inserted if on an empty line. To my understanding comment-dwim would > only insert @ style comments. Hmm... comment-dwim doesn't care, AFAIK, it just inserts whatever you have set for comment-start and comment-end, so it can definitely insert /*...*/. But I suspect you know that, so most likely I'm misunderstanding something. > The reason that (modify-syntax-entry ?_ "w" st) is there is actually define > a help define what a word is for the \< and \> regexp. If it is left out > then registers names or anything else used in labels will be highlighted in > their own color. Ah, I see. You can probably solve this by using \_< and \_> which match symbol-boundaries instead of word-boundaries. Stefan