From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master aae9ac2: Avoid an infloop in shr when filling text with :align-to properties Date: Fri, 23 Aug 2019 03:47:44 -0400 Message-ID: References: <20190823065141.21832.91029@vcs0.savannah.gnu.org> <20190823065143.0C45320E34@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="117802"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 23 09:49:45 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i14KL-000URL-QM for ged-emacs-devel@m.gmane.org; Fri, 23 Aug 2019 09:49:42 +0200 Original-Received: from localhost ([::1]:52464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i14KK-0007hv-MM for ged-emacs-devel@m.gmane.org; Fri, 23 Aug 2019 03:49:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36868) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i14Ij-0007hL-D1 for emacs-devel@gnu.org; Fri, 23 Aug 2019 03:48:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i14Ih-0007Oh-3W for emacs-devel@gnu.org; Fri, 23 Aug 2019 03:48:00 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:1575) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i14If-0007LY-TP for emacs-devel@gnu.org; Fri, 23 Aug 2019 03:47:59 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4790A100E9E; Fri, 23 Aug 2019 03:47:47 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DEBAF100DC8; Fri, 23 Aug 2019 03:47:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1566546465; bh=ZexwEkwXewPT1WaoVtxp67g5/iWWvgTsM8Bc541ZYLY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=pRac4aKzOcMXVXvo/drVCkOx/feYX0L1tgF8iX19ThjBXH4UcyT1NW8A/eOw34+la 6KEeukWK2L2PEpEdzy4KDjRYAYtVGRKCONPolNFD2fHtZwCTRcoF+Uus5ZWh62h8GD l5HpBWVMIX0pvbJyMTglZR/tmwn2nvlXr0RtJQaRoipwhCQdLoDjaT3mJWEWPVDS5a h5doJN2lbI6i2zQtRDHCKmqV/LCDuMU2tzQMDjevNtyyswkZ2McaKw9ThEysV2Ylp3 N72S3Q5P30qStBM1RbCXHD+5I7Sn425uGXdHwXvhOxUUEb4HuVUSygTMzMKUIt5oQY 1BBlqmuXFjAYg== Original-Received: from alfajor (unknown [46.189.28.40]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3D1821203FD; Fri, 23 Aug 2019 03:47:45 -0400 (EDT) In-Reply-To: <20190823065143.0C45320E34@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Fri, 23 Aug 2019 02:51:42 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239500 Archived-At: Hi Lars, I hope you had a nice vacation. > @@ -2363,6 +2364,7 @@ flags that control whether to collect or render objects." > (car (window-text-pixel-size nil (point-min) (point-max))))))) > > (defun shr-render-td (dom width fill) > + (setq d dom) > (let ((cache (intern (format "shr-td-cache-%s-%s" width fill)))) > (or (dom-attr dom cache) > (and fill Really? Stefan