From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: autoload cl-defstruct constructor? Date: Sat, 07 Sep 2019 10:29:12 -0400 Message-ID: References: <86k1anriz5.fsf@stephe-leake.org> <86ef0u8geu.fsf@stephe-leake.org> <86a7bh83l2.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="201555"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 07 16:29:55 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i6bir-000qK9-Ek for ged-emacs-devel@m.gmane.org; Sat, 07 Sep 2019 16:29:53 +0200 Original-Received: from localhost ([::1]:35354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i6biq-0005ne-Ai for ged-emacs-devel@m.gmane.org; Sat, 07 Sep 2019 10:29:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57265) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i6biJ-0005my-9p for emacs-devel@gnu.org; Sat, 07 Sep 2019 10:29:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i6biH-0002P6-Fl for emacs-devel@gnu.org; Sat, 07 Sep 2019 10:29:18 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4537) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i6biH-0002OF-97 for emacs-devel@gnu.org; Sat, 07 Sep 2019 10:29:17 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CBB94100EEF; Sat, 7 Sep 2019 10:29:15 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4DD92100EB8; Sat, 7 Sep 2019 10:29:14 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1567866554; bh=jPjmbJipkqqj0CivC+PbQzqI4gWhcnZpwfvFUf1jeSg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=oUO0Olv5YTsZldHJ/eC8JDeT0xUCJC4mdnxhCN8AM89BZicLLTQb7bA5RBeGzgIhK gHVwUf5dcvpMPfhCbQOo2gt7H7hDKpFQfc0G11cXH/ec3KNSUKRuFGAEA3JAXRSQgF jk8CvXk8YRggIaj23ls+X5+9hkBmaBUDLIA5aWPwsnMokAM0rFKi+SS6dOzAiJLeoc 5UfiG9wmsm+ylQW+hi6y+Cnj9rMS14pUe9htW5qPk/BVhE8aI2LXlsIhouMIrUGr3O Jpa69Z+QG6DaHgxQAMUGF1djGNS91CXqyk8nE8keKRn9MXonWofwqLVrnDQYpCY9Fm A/fZWWp+UFvKA== Original-Received: from pastel (unknown [157.52.13.58]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E5CF01204BC; Sat, 7 Sep 2019 10:29:13 -0400 (EDT) In-Reply-To: <86a7bh83l2.fsf@stephe-leake.org> (Stephen Leake's message of "Fri, 06 Sep 2019 15:25:29 -0700") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239928 Archived-At: > Hmm. To build autoloads.el for ada-mode in my development tree, I run: > > emacs -Q -batch --eval "(progn (require 'autoload)(require 'cl-lib)(setq > generated-autoload-file (expand-file-name > \"../autoloads.el\"))(update-directory-autoloads \"../\"))" > > I just added the (require 'cl-lib), but I still get the same result for > a cl-defstruct: Hmm... indeed it looks like you also need the patch below. > We'll need to ensure package.el does the same when it generates > autoloads. Or is that done on the elpa server? Indeed. The autoloads are built when *installing* a package, so they're built by the user's Emacs, which may be "old". Stefan diff --git a/lisp/emacs-lisp/autoload.el b/lisp/emacs-lisp/autoload.el index 541b22e3ee..8ec5150cca 100644 --- a/lisp/emacs-lisp/autoload.el +++ b/lisp/emacs-lisp/autoload.el @@ -165,7 +165,7 @@ make-autoload define-globalized-minor-mode defun defmacro easy-mmode-define-minor-mode define-minor-mode define-inline cl-defun cl-defmacro cl-defgeneric - pcase-defmacro)) + pcase-defmacro cl-defstruct)) (macrop car) (setq expand (let ((load-file-name file)) (macroexpand form))) (memq (car expand) '(progn prog1 defalias)))