From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: "João Távora" <joaotavora@gmail.com>
Subject: Re: master 7fc0292: Allow completion styles to adjust completion metadata
Date: Sat, 26 Oct 2019 12:12:50 -0400 [thread overview]
Message-ID: <jwva79ncwwa.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20191026121259.B54E720664@vcs0.savannah.gnu.org> ("João Távora"'s message of "Sat, 26 Oct 2019 08:12:59 -0400 (EDT)")
> +(cl-defgeneric completion-adjust-metadata-for-style (style metadata)
> + "Adjust METADATA of current completion according to STYLE."
> + (:method (_style _metadata) nil) ; nop by default
Hmm... if "nop" is to return nil, it means it works by side-effect, but
if the metadata is `nil` to start with, there's no side-effect that can
turn it into a non-nil value, right?
So I think it should work by returning a new metadata and hence "nop"
should be to return `metadata` unmodified.
> + (let ((alist (cdr metadata)))
> + (setf (alist-get 'display-sort-function alist)
> + (compose-flex-sort-fn (alist-get 'display-sort-function alist)))
> + (setf (alist-get 'cycle-sort-function alist)
> + (compose-flex-sort-fn (alist-get 'cycle-sort-function alist)))
This works by side-effecting the alist, but those entries may (and
usually) come from immediate constants in the code, so this is
like "self-modifying code" :-(
> + metadata))))
I see here you do return the metadata, good.
> + (result-and-style
> + (completion--some
> + (lambda (style)
> + (let ((probe (funcall (nth n (assq style
> + completion-styles-alist))
> + string table pred point)))
> + (and probe (cons probe style))))
> + (completion--styles metadata))))
> + (completion-adjust-metadata-for-style (cdr result-and-style) metadata)
> (if requote
But here it appears you're not using the return value, unless I'm
missing something.
Stefan
next parent reply other threads:[~2019-10-26 16:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191026121258.26047.33907@vcs0.savannah.gnu.org>
[not found] ` <20191026121259.B54E720664@vcs0.savannah.gnu.org>
2019-10-26 16:12 ` Stefan Monnier [this message]
2019-10-26 16:59 ` master 7fc0292: Allow completion styles to adjust completion metadata João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva79ncwwa.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.