From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Mon, 20 Jan 2020 18:04:35 -0500 Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="18090"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io, Dmitry Gutov To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 21 00:06:36 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1itg7v-0004Wg-ME for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Jan 2020 00:06:35 +0100 Original-Received: from localhost ([::1]:45444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itg7u-0005lu-Ga for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jan 2020 18:06:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58853) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itg6R-0004R6-RQ for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 18:05:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itg6Q-0004yU-QH for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 18:05:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40261) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1itg6Q-0004yC-Js for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 18:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1itg6Q-0006JI-FH for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 18:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Jan 2020 23:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157956148824234 (code B ref 38992); Mon, 20 Jan 2020 23:05:02 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 20 Jan 2020 23:04:48 +0000 Original-Received: from localhost ([127.0.0.1]:46234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itg6C-0006Io-J6 for submit@debbugs.gnu.org; Mon, 20 Jan 2020 18:04:48 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itg68-0006IU-DL for 38992@debbugs.gnu.org; Mon, 20 Jan 2020 18:04:47 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D9B6944083C; Mon, 20 Jan 2020 18:04:38 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DA71F440816; Mon, 20 Jan 2020 18:04:37 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1579561477; bh=Wz9GDT/WupQY/Ic69FdsWSg1hnyhDr8QgQRSD0vdo3U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=U9RmHnJhAOqtRf1/WZC6jyZwPebkYrgxTol+aSq26hdfsJsjWBXRulFaoPF/50vuo EkP8v+FmYipqrkuDLZrn+a/8U4fF5/totdLEDRvbR+u12ibZehXL65Oev8ERgrF4Oy Tyzf5iEKI5gZH+6Hqwdt0pytuNyzFUMfnV/mEutwpx93WCZoYtCbFHiA5Epxmmy64K dUcLNf+2Qdat1ebRGT5ktdstKlZCDWdgT2pG28dkCoHzP8YjzN+zTN5kypafmxM4Z0 qLrj3OhKyCjYxF7wPhB5NdVmCC9AmDcrnEn84wzBEDOA4VPOjCcYITAZFBalKGF68A H9C2lNRXfm7UA== Original-Received: from alfajor (unknown [45.72.156.100]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 795C512047F; Mon, 20 Jan 2020 18:04:37 -0500 (EST) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Mon, 20 Jan 2020 14:58:08 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174964 Archived-At: >> I'm not very familiar with the code. Do we really need the >> minibuffer-force-complete call there? I commented it out and can't see >> the difference. The `minibuffer-force-complete` call is the one which actually selects the "first candidate" from the list of completions, so I do think it's necessary. IIUC the bug under discussion is related to the `required` argument of `completing-read` (and to `minibuffer-completion-confirm`). If `required` was nil (as is the case in `grep-read-files` which I believe is the relevant function here), then when `test-completion` fails, we should probably just call `exit-minibuffer` (rather than tell the user that they should do that). The problem here is probably caused by the fact that fido-mode arranges for `minibuffer-force-complete` to choose the *default* rather than to choose a candidate from the completion table. It's rare for a completion table to return candidates that don't pass `test-completion` (tho it's by not impossible nor incorrect), but it's much less rare for the default not to pass `test-completion`. Stefan