From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: scanner Date: Fri, 10 Apr 2020 14:13:37 -0400 Message-ID: References: <871rov7dmc.fsf@mnet-mail.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="70503"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Raffael Stocker Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 10 20:14:14 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMyAP-000IF2-SG for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Apr 2020 20:14:13 +0200 Original-Received: from localhost ([::1]:37698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMyAO-0007xp-Kg for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Apr 2020 14:14:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53231) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMy9u-0007Z1-Ba for emacs-devel@gnu.org; Fri, 10 Apr 2020 14:13:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jMy9t-000686-3S for emacs-devel@gnu.org; Fri, 10 Apr 2020 14:13:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:25400) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jMy9s-00067W-TU for emacs-devel@gnu.org; Fri, 10 Apr 2020 14:13:41 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 28EE644FF21; Fri, 10 Apr 2020 14:13:40 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DFD1044FF1E; Fri, 10 Apr 2020 14:13:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1586542418; bh=bIzsKKog/Tvoe41BmAYKoUZmLUOALRaMn8IHWARxjyg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=pQl53r/CGjUQun96TXO40uwSattocr2cA/+mTejoN3xpUiQhAen9DaY+c2RezmeUU /10Sc691IvzgQpgiExGikEoXxuLg6UI3fOeb5FvLNDGFz7/wAZR6ZI0DT/kn07WRBn yMW9clC9w3l5ts8ZKCsj31EeYkCb7rjEES2/5MCLHCwD9UxmkrhPt8IlGuDEVdaLxA nYPZQJSzdSYtCDW8T+psEehW2SEFKfAPm+AKeLDkBmABZIJTpa2O7fEUpfJR13zZyu pEnR5ljKGtu9FsRnBvV/9Jz/iXOIgbKkiMzQZcQ8Q5KKSlNZCWJ1pmBhu42gfgHH2+ ViHbheLKZX/ng== Original-Received: from alfajor (unknown [104.247.241.114]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id ADBDE120784; Fri, 10 Apr 2020 14:13:38 -0400 (EDT) In-Reply-To: <871rov7dmc.fsf@mnet-mail.de> (Raffael Stocker's message of "Fri, 10 Apr 2020 14:02:19 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246788 Archived-At: > I have made a simple document scanning package that I would like to > contribute to ELPA. The source can be found here: > https://gitlab.com/rstocker/scanner.git Thanks, added. Beside some technical details I had to tweak as part of the addition, I noticed another problem: you add a submenu to the global menus (which I guess is fine), but some of the commands in that menu are not autoloaded so selecting them signals an error. You should probably "disable/grey" them until the package is loaded, or add autoloads, or ... I'm also wondering why you need all those `:key-sequence nil` in the menu. Maybe it reflects a bug in our code? Stefan