From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 9d0385d: Fix problem with 8bit content-transfer-encoding in nndoc mbox files Date: Fri, 21 Aug 2020 16:07:49 -0400 Message-ID: References: <83364fbx31.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18447"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 21 22:08:43 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k9DL8-0004jE-UH for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Aug 2020 22:08:42 +0200 Original-Received: from localhost ([::1]:41338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9DL7-0005lb-UW for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Aug 2020 16:08:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9DKa-0005Jx-5J for emacs-devel@gnu.org; Fri, 21 Aug 2020 16:08:08 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:21530) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9DKX-0004SF-HI; Fri, 21 Aug 2020 16:08:06 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9EF0F80F7A; Fri, 21 Aug 2020 16:08:03 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 34F1380541; Fri, 21 Aug 2020 16:08:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1598040482; bh=ptBt1gjsP1DIsKUJs/s3ehY5fAoVbpidJpim77bWytQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Peg5Ds5UtnvrbN8T4JLG9kDvoOOsE1xooftu2C75pTLzW96r587HPSGDY4fKiY/IE GQne9uIwGhSmtzeAF32czrzmW0I4UVcAXiQF8e7PCUNnbcM44Fp8XLzU/WQtELmALT mbD2cUomPXHgpWhDivn/qLOSLVL/4eeKtPQ8zBFgQ3t0A91F4h49E69IQR3KBMshT/ IPqpMAzR6aQQYq3v1oOp2Wp+IAPDDFGMqDvs7lUk3lCo2Cs7ENAFE7nTa07kxRKEyQ 7bMEXgVCqJNSV3f69YkhU/I29w0Rt1ahwIfNDB7+++4wXPXJV83fBime2m4gxyN0Oj n/fbhp9pDzAkg== Original-Received: from alfajor (unknown [45.72.246.108]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D50A6120642; Fri, 21 Aug 2020 16:08:01 -0400 (EDT) In-Reply-To: <83364fbx31.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 21 Aug 2020 22:47:14 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/21 16:08:03 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254088 Archived-At: > I think you want to swap the order: first erase-buffer, and then > set-buffer-multibyte. That's because the latter in a non-empty buffer > can be expensive, and tis actually waste of cycles if you are going to > erase the buffer. Indeed, IMNSHO `set-buffer-multibyte` should signal an error when the buffer is not empty ;-) Stefan