Uniquify change [PATCH]

Uniquify change [PATCH]

[Ergus]

[-- Attachment #1: Type: text/plain, Size: 128 bytes --]

Hi:

I want to add this patch to master. Could you give it a look and suggest
where in NEWS I should mention this?

Best, Ergus

[-- Attachment #2: uniquify.patch --]
[-- Type: text/plain, Size: 1446 bytes --]

diff --git a/lisp/uniquify.el b/lisp/uniquify.el
index 70e8ecee74..8439d9d874 100644
--- a/lisp/uniquify.el
+++ b/lisp/uniquify.el
@@ -104,6 +104,13 @@ uniquify-buffer-name-style
   post-forward-angle-brackets   name<bar/mumble>   name<quux/mumble>
   nil                           name               name<2>
 
+The value can be set to a customized function with two mandatory
+arguments.  For example the current implementation for
+post-forward-angle-brackets could be:
+
+(defun my-post-forward-angle-brackets (base extra-string)
+  (concat base \"<\" (mapconcat 'identity extra-string \"/\") \">\"))
+
 The \"mumble\" part may be stripped as well, depending on the
 setting of `uniquify-strip-common-suffix'.  For more options that
 you can set, browse the `uniquify' custom group."
@@ -111,6 +118,7 @@ uniquify-buffer-name-style
 		(const reverse)
 		(const post-forward)
 		(const post-forward-angle-brackets)
+                (function :tag "Other")
 		(const :tag "numeric suffixes" nil))
   :version "24.4"
   :require 'uniquify)
@@ -378,6 +386,8 @@ uniquify-get-proposed-name
      ((eq uniquify-buffer-name-style 'post-forward-angle-brackets)
       (concat base "<" (mapconcat 'identity extra-string "/")
 	      ">"))
+     ((functionp uniquify-buffer-name-style)
+      (funcall uniquify-buffer-name-style base extra-string))
      (t (error "Bad value for uniquify-buffer-name-style: %s"
 	       uniquify-buffer-name-style)))))
 

Re: Uniquify change [PATCH]

[Stefan Monnier]

> I want to add this patch to master. Could you give it a look and suggest
> where in NEWS I should mention this?

Looks very good to me.  See below for the nitpicks,

> diff --git a/lisp/uniquify.el b/lisp/uniquify.el
> index 70e8ecee74..8439d9d874 100644
> --- a/lisp/uniquify.el
> +++ b/lisp/uniquify.el
> @@ -104,6 +104,13 @@ uniquify-buffer-name-style
>    post-forward-angle-brackets   name<bar/mumble>   name<quux/mumble>
>    nil                           name               name<2>
>  
> +The value can be set to a customized function with two mandatory
> +arguments.  For example the current implementation for
> +post-forward-angle-brackets could be:

You should describe those arguments rather than only tell the number of
args and show an example.  E.g.

    The value can be set to a customized function which will be called
    two arguments BASE and EXTRA-STRINGS where BASE is a string and
    EXTRA-STRINGS is a list of strings.  For example the current
    implementation for post-forward-angle-brackets could be:

> +(defun my-post-forward-angle-brackets (base extra-string)
> +  (concat base \"<\" (mapconcat 'identity extra-string \"/\") \">\"))

I'd use #' rather than ' to quote `identity`.


        Stefan

Re: Uniquify change [PATCH]

[Ergus]

On Sun, Sep 13, 2020 at 03:02:44PM -0400, Stefan Monnier wrote:
>> I want to add this patch to master. Could you give it a look and suggest
>> where in NEWS I should mention this?
>
>Looks very good to me.  See below for the nitpicks,
>
>> diff --git a/lisp/uniquify.el b/lisp/uniquify.el
>> index 70e8ecee74..8439d9d874 100644
>> --- a/lisp/uniquify.el
>> +++ b/lisp/uniquify.el
>> @@ -104,6 +104,13 @@ uniquify-buffer-name-style
>>    post-forward-angle-brackets   name<bar/mumble>   name<quux/mumble>
>>    nil                           name               name<2>
>>
>> +The value can be set to a customized function with two mandatory
>> +arguments.  For example the current implementation for
>> +post-forward-angle-brackets could be:
>
>You should describe those arguments rather than only tell the number of
>args and show an example.  E.g.
>
>    The value can be set to a customized function which will be called
>    two arguments BASE and EXTRA-STRINGS where BASE is a string and
>    EXTRA-STRINGS is a list of strings.  For example the current
>    implementation for post-forward-angle-brackets could be:
>
>> +(defun my-post-forward-angle-brackets (base extra-string)
>> +  (concat base \"<\" (mapconcat 'identity extra-string \"/\") \">\"))
>
>I'd use #' rather than ' to quote `identity`.
>
>
>        Stefan
>
>
There is a new branch feature/uniquify-as-function.  I added some
documentation too. If it is fine confirm to merge into master.