From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Move 'with-buffer-modified-unmodified' to simple.el Date: Fri, 18 Sep 2020 15:56:54 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24546"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 18 22:02:21 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJMaK-0006Hr-Sz for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Sep 2020 22:02:20 +0200 Original-Received: from localhost ([::1]:34906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJMaJ-0002JI-UA for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Sep 2020 16:02:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJMVA-0007DE-Ei for emacs-devel@gnu.org; Fri, 18 Sep 2020 15:57:04 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:39476) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJMV8-0008Hd-G2 for emacs-devel@gnu.org; Fri, 18 Sep 2020 15:56:59 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3ED974411F9; Fri, 18 Sep 2020 15:56:57 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7F8094411F7; Fri, 18 Sep 2020 15:56:55 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1600459015; bh=/5XYsFUBTna0zvzpF/7Ouef+tvMsqxKi8VhfO3yFGPM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=EJ5jXWrO6cOqbLFGNJWv2uF3Sjl4rzDuZ6HWff1ht2hBgK+iWj3/9WbqA8BhcSQtl FISNNEhk8rtq1boqwhJobpD1E5Pba0tdjL+E2JGs8dVJsZWWu3lEsaLbcNAri65Vns QmzJ8RL7Zg8lsRJeNGNabWbGIP7eWFuSFnbbU9weSqJkdt9k4F6aq9MFUb1PW4igtA kLnUCFrTxuudVdFD0N6EDAfsuBZziNIEI77Yp4zu1+ar+8xmGltiDGm6R4w+FksptS YykroXX8qIdweInCSxWFwR9PHzy3xjOFRuo6bITQqCO7JgGx0/e0r9S5wqyJsMYAHv AKVRSnD81dzFg== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4A2A8120034; Fri, 18 Sep 2020 15:56:55 -0400 (EDT) In-Reply-To: (Yuan Fu's message of "Fri, 18 Sep 2020 14:25:25 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 15:49:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256130 Archived-At: > How should we determine if the extra bindings in `with-silent-modificatio= ns=E2=80=99 > aren=E2=80=99t right? In my understanding `with-silent-modifications=E2= =80=99 should only be > used when changing text properties and if you actually insert something y= ou > should use `with-buffer-modified-unmodified=E2=80=99. Is that correct? I think so, yes. > Looking though the result of the grep, I see some text property changes a= nd > some content changes. How many cases (approximately) involve content changes? > But the content changes seems to appear in program-generated buffers > so I=E2=80=99m not sure if `with-silent-modifications=E2=80=99 would do a= ny > harm anyway. `with-silent-modifications=E2=80=99 would prevent jit-lock from doing its j= ob, so it would interfere with the use (within that buffer) of any package that depends on jit-lock, such as font-lock-mode, nlinum-mode, nhexl-mode, goto-address-mode, bug-reference-mode, glasses-mode. Stefan