all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Dealing with obsoletion warnings in non-core code
Date: Mon, 28 Sep 2020 15:24:36 -0400	[thread overview]
Message-ID: <jwva6x9zozh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83imbxlqc6.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 28 Sep 2020 21:16:09 +0300")

>> > Ideally I'd like to be able to write the following instead to avoid the
>> > needless repetition:
>> >
>> >     (if (fboundp 'recommended-function)
>> >         (recommended-function)
>> >       (old-but-useful-function))
>> 
>> Indeed, it's a problem of which I'm aware but I don't know how to solve
>> it nicely.
>
> What about something like the below?
>
>   (if (> emacs-major-version NN)
>     (defun recommended-function (...)
>       ...))

I'm not sure I understand what you mean.  You're suggesting to replace
the `fboundp` test above with something like:

    (if (< emacs-major-version NN)
      (defun recommended-function (...)
        ...
        (old-but-useful-function)
        ...))

    [...]

        (recommended-function)

?  If so, I fail to see how it helps.  It will still result in an obsolete
warning on new Emacsen (and adds an "unknown function" warning on old ones).

Or did I misunderstand your suggestion?


        Stefan




  parent reply	other threads:[~2020-09-28 19:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28 14:35 Dealing with obsoletion warnings in non-core code Vasilij Schneidermann
2020-09-28 17:32 ` Stefan Monnier
2020-09-28 18:16   ` Eli Zaretskii
2020-09-28 18:34     ` Vasilij Schneidermann
2020-09-28 19:00       ` Eli Zaretskii
2020-09-28 19:24     ` Stefan Monnier [this message]
2020-09-29 14:07       ` Eli Zaretskii
2020-09-29  8:21 ` Gregory Heytings via Emacs development discussions.
2020-09-29  8:28   ` Gregory Heytings via Emacs development discussions.
2020-09-29  9:33     ` Gregory Heytings via Emacs development discussions.
2020-09-29 13:11   ` Stefan Monnier
2020-09-29 14:11     ` Gregory Heytings via Emacs development discussions.
2020-09-29 14:46       ` Stefan Monnier
2020-09-29 15:36         ` Gregory Heytings via Emacs development discussions.
2020-09-29 14:55     ` T.V Raman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwva6x9zozh.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.