From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@linkov.net>
Cc: 46268@debbugs.gnu.org
Subject: bug#46268: 27.1.91; Error in occur-rename-buffer
Date: Wed, 03 Feb 2021 10:05:43 -0500 [thread overview]
Message-ID: <jwva6sljjdn.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <874kitttd3.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 03 Feb 2021 10:54:24 +0200")
> Also Cc:ing Stefan with a question about occur--garbage-collect-revert-args:
[ Side note: Not sure why, I'm not familiar with this code. ]
> trying to revert the Occur buffer created from an active region
> removes the source buffer name from the Occur buffer name.
> For example, (after applying the attached patch) 'M-x occur'
> on the active region in *scratch* creates the buffer *Occur: *scratch**.
>
> But reverting the Occur buffer with 'g' removes the *scratch* buffer name,
> and renames the Occur buffer to *Occur: *.
>
> This is because of two lines in occur-1:
>
> (occur--garbage-collect-revert-args)
> (setq occur-revert-arguments (list regexp nlines bufs))
>
> where occur--garbage-collect-revert-args deletes the overlay
> with the buffer name *scratch*, and later occur-rename-buffer
> can't get the original buffer name from occur-revert-arguments.
> And I don't know how to fix this.
AFAICT, `occur--garbage-collect-revert-args` aims to throw away the
overlays when they're not needed, but we will need them again if we want
to `revert-buffer`, so we shouldn't call this function until we're sure
`revert-buffer` won't be called. IOW, I think we should just remove
the above call.
[ I just took a look at the history of this code, and I see that it
claims I'm the one who added that function and that call 2 years
ago. I say this is fake news ;-) ]
Stefan "not sure it's a good idea to joke about the
re-birth of nazism"
next prev parent reply other threads:[~2021-02-03 15:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 8:54 bug#46268: 27.1.91; Error in occur-rename-buffer Juri Linkov
2021-02-03 15:05 ` Stefan Monnier [this message]
2021-02-03 15:38 ` Stefan Monnier
2021-02-03 17:34 ` Juri Linkov
2021-02-03 15:22 ` Stefan Monnier
2021-02-03 17:36 ` Juri Linkov
2021-02-03 19:41 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva6sljjdn.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=46268@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.