From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: modus-themes ELPA and etc/themes Date: Sat, 20 Mar 2021 16:39:31 -0400 Message-ID: References: <8335wpd166.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15573"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 20 21:40:17 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNiOM-0003vw-PS for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Mar 2021 21:40:14 +0100 Original-Received: from localhost ([::1]:53792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNiOL-0007Pb-RV for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Mar 2021 16:40:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNiNm-0006z9-LN for emacs-devel@gnu.org; Sat, 20 Mar 2021 16:39:38 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:51981) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNiNj-0005Bb-V4; Sat, 20 Mar 2021 16:39:37 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 830B480A9C; Sat, 20 Mar 2021 16:39:34 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F2A31805C1; Sat, 20 Mar 2021 16:39:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1616272772; bh=ycabhulvyikFG1+zvKDHvKPialT2TMntHnZRFy8CU7U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=FotbvSMmJVRnAjnKNgKwxLXNON/lFYarUqPRht+ywkHwT1vUJGteHAiKP8APEVw/A 3FcHl9qverWU/poSG8S5eJlWgUKFuucmbPY6qtd0KhZz7VSQBqHKxgLF7Tc48y3V4W YPHvCdlZb5EVHfL/4WzaF7ZWoMDmmjeBFcdye4TmyF70n0ThQmQrMpoqwZ6zN0rEPz NfutzDycL1daHmrhoX8jJ5Cm9ew8jeIOXQw0CVfy3EG7YgndgYwiR9J8EmL7R7/ZEK FPxF8XR7+X4OmJ3G2gc3FVpZ6A/6g2T40cWvYeAd38jn+2VTkCZFy1VX+gzgWFxm10 e679ojTBj4DJA== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C05C91203FF; Sat, 20 Mar 2021 16:39:32 -0400 (EDT) In-Reply-To: <8335wpd166.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 20 Mar 2021 22:23:45 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266672 Archived-At: >> The problem is due to the fact that the file is under `etc/themes` and >> is hence not processed by our autoloads machinery which would otherwise >> add something like >> >> (push (purecopy '(modus-themes 1 2 4)) package--builtin-versions) >> >> to lisp/loaddefs.el. >> >> There are various ways to fix this, but to me the simplest would be to >> move `etc/themes` to `lisp` (or at least to move `modus-themes.el`). > > I'd rather we didn't move files around. If nothing else, it makes > forensics harder down the line. Besides, we had themes in that place > for too long to make such changes now, and for this minor reason on > top of that. OK, so it's a definite no for moving `etc/themes`. How 'bout moving just `modus-themes.el` (it's a fresh new file, so the forensics aspect shouldn't matter that much, especially since the real Git history is in the upstream repository rather than in emacs.git anyway)? Part of the reason why `modus-themes.el` could be treated differently is that it actually contains a fair bit of ELisp code, so it would make sense to compile it. > Why can't we take any of the other ways to fix this? Oh, we definitely can, I'm just trying to figure out which solution is best. Stefan