From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51368: 29.0.50; `cl-case' should error on incorrect use Date: Sun, 14 Nov 2021 10:08:51 -0500 Message-ID: References: <87a6iy71q1.fsf@gnus.org> <87v91ct330.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30977"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 51368@debbugs.gnu.org, Lars Ingebrigtsen To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 14 16:10:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmH99-0007tb-HS for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Nov 2021 16:10:19 +0100 Original-Received: from localhost ([::1]:35424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmH97-0006g6-NG for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Nov 2021 10:10:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55232) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmH8s-0006fs-IG for bug-gnu-emacs@gnu.org; Sun, 14 Nov 2021 10:10:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39788) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmH8s-0001iH-7K for bug-gnu-emacs@gnu.org; Sun, 14 Nov 2021 10:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mmH8s-0002YR-1n for bug-gnu-emacs@gnu.org; Sun, 14 Nov 2021 10:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Nov 2021 15:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51368 X-GNU-PR-Package: emacs Original-Received: via spool by 51368-submit@debbugs.gnu.org id=B51368.16369025429745 (code B ref 51368); Sun, 14 Nov 2021 15:10:02 +0000 Original-Received: (at 51368) by debbugs.gnu.org; 14 Nov 2021 15:09:02 +0000 Original-Received: from localhost ([127.0.0.1]:51334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmH7u-0002X7-Ei for submit@debbugs.gnu.org; Sun, 14 Nov 2021 10:09:02 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmH7s-0002Wb-Fh for 51368@debbugs.gnu.org; Sun, 14 Nov 2021 10:09:01 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9CBA5440B41; Sun, 14 Nov 2021 10:08:54 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 28B84440B1F; Sun, 14 Nov 2021 10:08:53 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1636902533; bh=RF6FM7cjZV36XDAiB/vjEJwNboA7KkgGLk31S8dP9Dk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kb5x+zbf9SN9hHgaTwsUWGGdxBNAQJiD9W5Jhvws2iDwMHPFWkE0DXCdfibFSelFM 7keb41LzDvMHMNDkFlv/t0nQOReztaMpw2yffbXxo9fAiEGnZgGjFsRMzYJ4OMX8iX cYybUheuuHhCQYsUPYnBnDU6gqgxfK2nA/6dbnq0iET/vCBcYoxDMUXjQGPDfwda2w NuNVIfFV2ZO5JXhbGiUjCrlinZr8zoANkNUfLpELrRpdU2t1Tib+5raVzNkiai1lm0 fahNsFy6weu3M7rxireml70jaOtjckTAyFddWwyNk+D8w2ivtMwnx9Dqc0gzyMMOb3 vEhu7aIKuZP4Q== Original-Received: from pastel (unknown [45.72.128.33]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BF543120893; Sun, 14 Nov 2021 10:08:52 -0500 (EST) In-Reply-To: (Philipp Stephani's message of "Fri, 12 Nov 2021 20:34:13 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219952 Archived-At: > Ok, I've attached two patches that implement these suggestions. BTW, there's a third issue which is that (cl-case EXP ((a b) FOO) ((a c) BAR)) won't warn about the duplicate `a`. After fixing this, many/most uses of `quote` will already emit a warning, so maybe it would make the quote/function part of your second patch unnecessary. Personally, I just recommend the use of `pcase` over `cl-case` ;-) BTW, I just noticed the use of the `suspicious` category of warning messages. Doesn't this category apply to all warnings? Oh, and for the `nil` case and the presence of branches after `otherwise`, the warnings could use the same text saying the branch is unreachable. Stefan