Re: master c99e28207a: * lisp/tooltip.el (tooltip-show-help): Fix typo.

Re: master c99e28207a: * lisp/tooltip.el (tooltip-show-help): Fix typo.

[Stefan Monnier]

> -           (or (not (and haiku-use-system-tooltips
> -                         (eq window-system 'haiku)))
> +           (or (not (and (eq window-system 'haiku)
> +                         haiku-use-system-tooltips))

Could you merge this var with `x-gtk-use-system-tooltips`, maybe into
a `use-system-tooltips` var which can be either nil t or a list of
window-systems on which it should be true?


        Stefan

Re: master c99e28207a: * lisp/tooltip.el (tooltip-show-help): Fix typo.

[Po Lu]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Could you merge this var with `x-gtk-use-system-tooltips`, maybe into
> a `use-system-tooltips` var which can be either nil t or a list of
> window-systems on which it should be true?

I don't think the last option is necessary, since it will only take
effect on supported window systems, but otherwise that looks good to me.

Where do you think would be the best place to put such a variable
definition?

Thanks.

Re: master c99e28207a: * lisp/tooltip.el (tooltip-show-help): Fix typo.

[Stefan Monnier]

> I don't think the last option is necessary, since it will only take
> effect on supported window systems, but otherwise that looks good to me.

You're probably right.

> Where do you think would be the best place to put such a variable
> definition?

`tooltip.el` seems like the obvious choice.


        Stefan

Re: master c99e28207a: * lisp/tooltip.el (tooltip-show-help): Fix typo.

[Po Lu]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> `tooltip.el` seems like the obvious choice.

It has to be in C though.  Perhaps keyboard.c or frame.c would make more
sense.  WDYT?

Re: master c99e28207a: * lisp/tooltip.el (tooltip-show-help): Fix typo.

[Stefan Monnier]

Po Lu [2022-01-19 08:38:01] wrote:

> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> `tooltip.el` seems like the obvious choice.
>
> It has to be in C though.  Perhaps keyboard.c or frame.c would make more
> sense.  WDYT?

I'm probably the wrong person for this choice because I don't have
a clear understanding of what goes where in this part of the code, but
I think there are worse choices than `syms_of_display`.


        Stefan

Re: master c99e28207a: * lisp/tooltip.el (tooltip-show-help): Fix typo.

[Po Lu]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> I'm probably the wrong person for this choice because I don't have
> a clear understanding of what goes where in this part of the code, but
> I think there are worse choices than `syms_of_display`.

Hmm, I actually think it's more appropriate for frame.c (since tooltips
are usually a special kind of frame), so I'll put it there instead.

Thanks.

Re: master c99e28207a: * lisp/tooltip.el (tooltip-show-help): Fix typo.

[Po Lu]

Po Lu <luangruo@yahoo.com> writes:

> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> I'm probably the wrong person for this choice because I don't have
>> a clear understanding of what goes where in this part of the code, but
>> I think there are worse choices than `syms_of_display`.
>
> Hmm, I actually think it's more appropriate for frame.c (since tooltips
> are usually a special kind of frame), so I'll put it there instead.
>
> Thanks.

Now done.