From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master af0ea35ea0: Tweak how functions are formatted in Implementation in *Help* Date: Sat, 02 Apr 2022 15:30:15 -0400 Message-ID: References: <164872671963.30191.4037902323881017518@vcs2.savannah.gnu.org> <20220331113841.3BBFAC0581F@vcs2.savannah.gnu.org> <87pmm2qnkl.fsf@gmail.com> <87h77bliwl.fsf@gnus.org> <87zgl3im3j.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1076"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Robert Pluim , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 02 21:31:19 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1najSx-00005d-FR for ged-emacs-devel@m.gmane-mx.org; Sat, 02 Apr 2022 21:31:19 +0200 Original-Received: from localhost ([::1]:35042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1najSw-0008MJ-78 for ged-emacs-devel@m.gmane-mx.org; Sat, 02 Apr 2022 15:31:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1najSB-0007dd-DL for emacs-devel@gnu.org; Sat, 02 Apr 2022 15:30:31 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24226) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1najS8-0005HL-Um for emacs-devel@gnu.org; Sat, 02 Apr 2022 15:30:30 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 04897805C8; Sat, 2 Apr 2022 15:30:27 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4F3B6800AE; Sat, 2 Apr 2022 15:30:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1648927825; bh=S4q4m18Uxo2H5hgMIAX7H9EqWtXBq+wqOtT6JGaVUs0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=AfJd3z9MfJNYRan2aZJeyY/fvA+QkTOZ5qDyrb9uZmvyKRIK1bH1n9tIQ3tZ59NUY LVAWdqS5B7I00L04LT45q9ZGWsezXzNUrVU8p/tQv7K/qoONfCDFj78eoZZXT7SU3a JWbtt3JDEW+/Lwz0JKTV2bKg4eqomQ2c1sZ4YGP5Ro2c/8ijfMKF/x8DVO9yvxEUIz O3EXxwUDxWNHi0V+FtwQ6EExl9O0ESgeYHI+f8Y/D4SdZs3Mpo7YJkhiFpJKWU0DSy scZCs2o3KZXkf0lkw7W1i2OKhAubm+oA9TPNz35PCIx9H75bcFpePyUcXYkeIipB2M 6X/MMBCf1A3AQ== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1FDC21207F7; Sat, 2 Apr 2022 15:30:25 -0400 (EDT) In-Reply-To: <87zgl3im3j.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 02 Apr 2022 16:41:36 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287722 Archived-At: Lars Ingebrigtsen [2022-04-02 16:41:36] wrote: > Stefan Monnier writes: > >> Used internally for the (major-mode MODE) context specializers. >> >> :extra "typeof" (TYPE) in =E2=80=98cl-generic.el=E2=80=99. >> >> [...] >> >> The presence/absence of `cl-generic-generalizers` looks rather >> accidental/unexplained (IOW looks like a bug to me :-) > > I don't think it's more confusing than before, though. :-/ Before your recent changes it was: [...] ((SPECIALIZER (head derived-mode))) in =E2=80=98cl-generic.el=E2=80=99. Support for (derived-mode MODE) specializers. Used internally for the (major-mode MODE) context specializers. :extra "typeof" (TYPE) in =E2=80=98cl-generic.el=E2=80=99. [...] So the text matched the part after `(cl-defmethod cl-generic-generalizers` in the source code: (cl-defmethod cl-generic-generalizers ((specializer (head derived-mode)= ))) and (cl-defmethod cl-generic-generalizers :extra "typeof" (type) Maybe a way to solve the problem is to use something like: [...] (cl-generic-generalizers (SPECIALIZER (head derived-mode))) in =E2=80= =98cl-generic.el=E2=80=99. Support for (derived-mode MODE) specializers. Used internally for the (major-mode MODE) context specializers. (cl-generic-generalizers TYPE) in =E2=80=98cl-generic.el=E2=80=99. :extra "typeof" [...] Of course the `cl-generic-generalizers` is always redundant and risks pushing the line length past the window width, which was some of the reasons why I originally used just: [...] ((SPECIALIZER (head derived-mode))) in =E2=80=98cl-generic.el=E2=80=99. Support for (derived-mode MODE) specializers. Used internally for the (major-mode MODE) context specializers. :extra "typeof" (TYPE) in =E2=80=98cl-generic.el=E2=80=99. [...] -- Stefan