From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#55149: bug#55161: 29.0.50; [PATCH] oclosure transcription error redux Date: Thu, 28 Apr 2022 09:42:08 -0400 Message-ID: References: <87mtg5zt3a.fsf@dick> <87a6c5pkvr.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7876"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 55161-done@debbugs.gnu.org, dick , 55149-done@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 28 15:43:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nk4QI-0001py-Hv for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 15:43:10 +0200 Original-Received: from localhost ([::1]:42568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nk4QH-0006ej-5v for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 09:43:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk4QA-0006e6-Lh for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 09:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nk4QA-00039x-Be for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 09:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nk4QA-0005D8-9g for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 09:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2022 13:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55149-done@debbugs.gnu.org id=D55149.165115333819955 (code D ref 55149); Thu, 28 Apr 2022 13:43:02 +0000 Original-Received: (at 55149-done) by debbugs.gnu.org; 28 Apr 2022 13:42:18 +0000 Original-Received: from localhost ([127.0.0.1]:45843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk4PS-0005Bl-Iv for submit@debbugs.gnu.org; Thu, 28 Apr 2022 09:42:18 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:25384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk4PR-0005BV-BZ; Thu, 28 Apr 2022 09:42:17 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D049B100164; Thu, 28 Apr 2022 09:42:11 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 481E010027D; Thu, 28 Apr 2022 09:42:10 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651153330; bh=ZmzfrO5WmzGvSLc+GbJPtX8gxdGzoXh2jqs3LHCebqo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Pg8OtkkcO1A8+A3oh2xrhfnDutmbyzTdh6lk1rMdX+6x9fW8z/Nfon1M6AqiA52PJ 1eX04GEy76wFWF0IFhzfz1Cf+kDCGW2ubs+vGk+Iam2Mxwmebi3p4M4A/zanVsKoL7 FFuo4NYgyvWAwnNts0vEiI/sH0mziveuRDr9Rrz3By5oMxMKsQ/3EbgYTAEKqpJCC/ zeZgmXRBysivRkxnntueeBGD6Pz6asMKTQXVI5DBg9ADxsnXgdGrRjrdSL5qVd6F07 ClagRu+jYA5W9WjksxcjKz5ezsHbJzeBy/YYMHATpbVu/LgFUInbFm48jEoewYRmdq 1OIxb+f8tbUyg== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C1A5B120297; Thu, 28 Apr 2022 09:42:09 -0400 (EDT) In-Reply-To: <87a6c5pkvr.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 28 Apr 2022 12:23:04 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230880 Archived-At: Lars Ingebrigtsen [2022-04-28 12:23:04] wrote: > dick writes: > >> - (:after (apply cdr r) (apply car r)) >> + (:after (prog1 (apply cdr r) (apply car r))) > > I guess this is the same as bug#55149, so I've merged the reports. > > Apparently, returning the value of the :after function is what's > documented to happen (and is what the trunk does now), but it didn't > use to do that, so it's breaking advice that relies on the old > behaviour, if I understand 55149 correctly. > Stefan? Yes, I implemented the new code from the doc (since the old code was written in the form of an "undecipherable" bytecode string), but the doc was wrong. It's now fixed. Stefan