From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 979308b4ca 5/9: org-export-data: Concatenate strings in temporary buffer for performance Date: Thu, 16 Jun 2022 08:19:33 -0400 Message-ID: References: <165536698076.5328.17316430648307086249@vcs2.savannah.gnu.org> <20220616080945.7DD14C01685@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15789"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Ihor Radchenko To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 16 14:29:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1ocu-0003vZ-68 for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Jun 2022 14:29:32 +0200 Original-Received: from localhost ([::1]:49766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1oct-0001Br-6m for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Jun 2022 08:29:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1oTN-00060y-OX for emacs-devel@gnu.org; Thu, 16 Jun 2022 08:19:41 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:14939) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1oTJ-0007zE-CG for emacs-devel@gnu.org; Thu, 16 Jun 2022 08:19:39 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 07C95808D4; Thu, 16 Jun 2022 08:19:36 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B86D980012; Thu, 16 Jun 2022 08:19:34 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1655381974; bh=3DpL061pQDaCmu05HBeU/TG3zsK3EHNGX7SAh37txQo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=XIzS0WIvUaZ05sKhGvjcaHP4wlyUuOxPr3kWzuFKLzjnRfmTgjwtHD2MS9uXtQws8 BFhK+Bd/tRxTq7KD2wFWMfblwQhzhCfIxA+CHI7OVoWcnedYOBxqwrlyVveVSdGdKa kYWjyZQyuQEwHSCOPHqA+lNCHicw3tB+3TzAPTH59+VUj6iRqduID1X8wY2KPTGs4H Pq9KXW45AtwoNP7BCT7UZKcSay9JNLF88TN+n8uOKNYzI/N5XypjmgtB1AtK7cqUoY CsFJj6MOPAKY3yNZZH0bnXAxosBnTPyt0iichNzXIQdCnr98tGhWb+DEEGdvt+Bq6T 42C/3qZuWIWiA== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 92EEB120163; Thu, 16 Jun 2022 08:19:34 -0400 (EDT) In-Reply-To: <20220616080945.7DD14C01685@vcs2.savannah.gnu.org> (Eli Zaretskii's message of "Thu, 16 Jun 2022 04:09:44 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291240 Archived-At: Eli Zaretskii [2022-06-16 04:09:44] wrote: > org-export-data: Concatenate strings in temporary buffer for performance > > * lisp/org/ox.el (org-export-data): Use temporary buffer to collect export > data instead of `mapconcat'. Using buffer puts less load on garbage > collector. AFAICT this just replaces `mapconcat` with a `with-temp-buffer + dolist + insert`, so if this makes a significant performance difference, it points to a performance problem in our `mapconcat`, right? Stefan