From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Average-user-facing interface for tree-sitter Date: Fri, 21 Oct 2022 18:35:41 -0400 Message-ID: References: <3A7E7CD1-74A7-4352-9DFE-FC982EAA398E@gmail.com> <87ilko9r9e.fsf@gnus.org> <9794E2EF-4DB5-4A04-90F0-3EB51E6BE008@gmail.com> <87977C2D-844B-4F4E-BEA4-8BCBFC8AE354@gmail.com> <6A0F847F-910D-449B-B461-466493CC9847@gmail.com> <87sfjmg69q.fsf@gnus.org> <21B2ADDF-70BC-46D4-98D6-41C5D0EF7D40@gmail.com> <87edv4l6iw.fsf@thornhill.no> <7E474686-A204-493C-A168-48EE4856DC8A@gmail.com> <87r0z3gcse.fsf@thornhill.no> <87pmemmklo.fsf@thornhill.no> <374026E1-4BFC-4F62-B62E-94F61F4BCFA9@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15941"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Theodor Thornhill , Lars Ingebrigtsen , emacs-devel To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 22 01:39:43 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1om1c6-0003yn-Ib for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Oct 2022 01:39:42 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1om0cJ-0007Zk-4s; Fri, 21 Oct 2022 18:35:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1om0cI-0007Zc-7D for emacs-devel@gnu.org; Fri, 21 Oct 2022 18:35:50 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1om0cF-00061R-0h for emacs-devel@gnu.org; Fri, 21 Oct 2022 18:35:49 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B08E7804C0; Fri, 21 Oct 2022 18:35:45 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B70E380261; Fri, 21 Oct 2022 18:35:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1666391743; bh=MITR54FGmIp+ZYfhr5lZxU4h8f7TL1DsCy08HTje7Bw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=duGnH26Dy8rnVdnaXi7seUqMexAgEmwSUfJwjQ45Ccdj5G7SrR33WZ7vQJfPfWqvS 4C84OVAGJYWNvy4opqLv0RdEI4w/OfA+AdkfVcA4+V29TEMvXHlDEK7h0RYL+GiRSA a/9OvVlnuf2/Uab1xdfU2yMXWsuUwNKik+DQ7moTGti8g4XPKP4LqFMIaEJvoA443D 1QybRzzikQYpbKqGA/n4yUc62kCmsm0bivkM4gZ5zMZ72c5MNoMSXqNRjQt2jE6/MU RESxfReVyulpmsD4C5gNGasXGV72ANDpudxFjB+2toU3xopWt00Bi/oUbz1588oecE h06Lh/d0E/dAg== Original-Received: from pastel (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 31453120E90; Fri, 21 Oct 2022 18:35:43 -0400 (EDT) In-Reply-To: (Yuan Fu's message of "Fri, 21 Oct 2022 15:10:41 -0700") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298244 Archived-At: >>> Yeah. Shouldn't it be possible to just have a global var instead of a >>> mode? That way we can just look for that variable when enabling the >>> mode, and avoid calling anything other than what we want. At least for >>> the foreseeable future, enabling these per mode in the init file >>> shouldn't really be too much of a problem, IMO. When more users >>> actually get to try this we can get a feel for how the init should best >>> be handled. >>>=20 >>> To me the '*-use-tree-siter' defcustoms was beautiful :) >>=20 >> Back to centralized variable, perhaps? > > I=E2=80=99ve thought really hard but didn=E2=80=99t come up with any bril= liant ideas, so I=E2=80=99m > going with centralized variable. Now, should I throw away recent commits = and > create a new branch so we don=E2=80=99t have so many changes back and for= th on js.el > and python.el? Plus feature/tree-sitter wouldn=E2=80=99t be used for long= anyway > since it=E2=80=99s merging into master soon. I'd wait a bit more to see if some other ideas come up first. Stefan