From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58975: 29.0.50; noverlay fails to build with --enable-checking=structs Date: Wed, 02 Nov 2022 21:55:07 -0400 Message-ID: References: <874jvg3n8z.fsf@tcd.ie> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27763"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Matt Armstrong , 58975@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 03 02:56:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqPSt-0006xF-NY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Nov 2022 02:56:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqPSe-0002S1-Hg; Wed, 02 Nov 2022 21:56:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqPSc-0002Qe-Vq for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 21:56:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqPSc-0005Vp-Nr for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 21:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oqPSc-00053Q-7I for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 21:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Nov 2022 01:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58975-submit@debbugs.gnu.org id=B58975.166744052819386 (code B ref 58975); Thu, 03 Nov 2022 01:56:02 +0000 Original-Received: (at 58975) by debbugs.gnu.org; 3 Nov 2022 01:55:28 +0000 Original-Received: from localhost ([127.0.0.1]:47453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqPS4-00052c-Bf for submit@debbugs.gnu.org; Wed, 02 Nov 2022 21:55:28 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqPS2-00052O-AI for 58975@debbugs.gnu.org; Wed, 02 Nov 2022 21:55:26 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4592380058; Wed, 2 Nov 2022 21:55:20 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 84B348005E; Wed, 2 Nov 2022 21:55:14 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1667440514; bh=V6tX5uxT4yfK8NG3YEr6FMiIJDhvQEQZs4/FbLYzBJw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=BXbnpSpK/dGbWzf/LOtX5zbX4Ir2X8LFoD5tpSV5GpyV6LGpGOM/GnbwZt5y+MJ9v In7IKNKpJbTGk0smkMfOuTpsT15lT/Lg28Dqp8PgqK0+aDQ9ZaOE9Pu2sYhZRRRWdi sftHG13tXV2tfTsb1QVtd0TBHh2GEJZDTiNBSTwvR8BZwFO1lBhKZeKl99oSslC06k +nrT1dQppg2kna90sObl9Le2W8n+kedmE0cPtCMJ/DQDYnC/RvSEm7hFObU+pRWg8N XE0uZFjFT9BnI0G872d8ABUc5rKPmLFeR4m43/KMXrxAsfK6xFSEDjPvbuLG8rNAzA ONeAIK0D7Ehdw== Original-Received: from pastel (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 53D3B1201B6; Wed, 2 Nov 2022 21:55:14 -0400 (EDT) In-Reply-To: <874jvg3n8z.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 03 Nov 2022 02:17:16 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246905 Archived-At: > Is this the right fix? The patch looks good, thanks. > BTW, every time itree_create is called via add_buffer_overlay, it in > turn calls itree_init, Oh, that's not right. `itree_init` should be called once only, from `emacs.c`, like things like `init_lread`. > which calls itree_iterator_create, which xmallocs a new > itree_iterator, interval_stack, and itree_nodes. Is this memory leak > going to rust my computer? No, Emacs is pure C and ELisp, so it doesn't suffer from Rust. Stefan