From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Sun, 16 Jul 2023 10:04:30 -0400 Message-ID: References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <83r0p9b3om.fsf@gnu.org> <83jzv1b152.fsf@gnu.org> <83a5vxas9k.fsf@gnu.org> <871qh8o12z.fsf@localhost> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5866"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 64596@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 16 16:05:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qL2NI-0001JA-AR for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jul 2023 16:05:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qL2Mx-0007KZ-UH; Sun, 16 Jul 2023 10:05:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qL2Mw-0007KM-MY for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 10:05:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qL2Mw-0007WY-E3 for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 10:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qL2Mv-0004aE-TX for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 10:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jul 2023 14:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168951628317570 (code B ref 64596); Sun, 16 Jul 2023 14:05:01 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 16 Jul 2023 14:04:43 +0000 Original-Received: from localhost ([127.0.0.1]:48335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL2Md-0004ZJ-BQ for submit@debbugs.gnu.org; Sun, 16 Jul 2023 10:04:43 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL2MY-0004Yu-Dw for 64596@debbugs.gnu.org; Sun, 16 Jul 2023 10:04:42 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1D98A442854; Sun, 16 Jul 2023 10:04:33 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D0B7944284E; Sun, 16 Jul 2023 10:04:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1689516271; bh=cIaUwIGQOb4vf/MZMp1xcfzso8EDp4gG2HQeNrvU5b0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=iJ1rQadE3wkhaxVAyU2tKVE9KaPzFhDjfqGmhcVmZaoSiAcRcDFYN6fqhpf8CAHBa 396o0Tat9lLrgzGIQ8EmwBUqcJJBHHGGGfdwGd4KrG2ucJqePQfXkXKFgRlcihCr8B fGYjDfIf64KiaIfKSSdsgnjWnEms+RNy5wLFzmNtqUS7Z026YvmFvldPBvVu1poeum MpnjBp+6Zqeg5pzYizO0Oyf71DuVcPF8iftyg2rz5KMP8zdx/B5rzdAuBKkq2Y1tLt obM1DNPR0YcTZUdLZ1ALy/0cbN0ECdLMw7ZsOENtWZuQlhZmDkTuXpGhtreA4/EIhL xlwqvFSxT0kAQ== Original-Received: from pastel (unknown [108.175.226.218]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A40501202FC; Sun, 16 Jul 2023 10:04:31 -0400 (EDT) In-Reply-To: <871qh8o12z.fsf@localhost> (Ihor Radchenko's message of "Sun, 16 Jul 2023 05:52:04 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265334 Archived-At: >> - /* True means redisplay has to consider all windows on all >> - frames. False, only selected_window is considered. */ >> + /* False, means that only the selected_window needs to be updated. >> + True means that other windows may need to be updated as well, >> + so we need to consult the `redisplay` bits of >> + all windows/buffer/frames. */ >> bool consider_all_windows_p; > > BTW, is there any particular reason why windows_or_buffers_changed is > not a queue of windows/buffer to be re-displayed? FWIW, I suspect that the loop over all windows is always insignificant, so (in theory) we could get rid of the optimization that looks only at the selected window in most cases and we wouldn't notice any slowdown or measurable increase in CPU use. So, replacing the `redisplay` bits with a queue is probably not a great idea (especially since setting a bit is much faster than adding an element to a queue where you need to try and avoid adding the same element a hundred times). Stefan