From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64927: 30.0.50; kill-ring with no X Date: Thu, 03 Aug 2023 12:30:36 -0400 Message-ID: References: <87edkrdp78.fsf@yandex.com> <87a5vfdko3.fsf@yandex.com> <838rasxxlw.fsf@gnu.org> <83y1isw1yl.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18358"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: m43cap@yandex.com, larsi@gnus.org, 64927@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 03 18:31:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRbEY-0004Zm-4H for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Aug 2023 18:31:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRbE9-00006y-SA; Thu, 03 Aug 2023 12:31:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRbE8-00005G-3s for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 12:31:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRbE6-0004qA-Ru for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 12:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRbE6-0002Ku-CA for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 12:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Aug 2023 16:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64927 X-GNU-PR-Package: emacs Original-Received: via spool by 64927-submit@debbugs.gnu.org id=B64927.16910802498959 (code B ref 64927); Thu, 03 Aug 2023 16:31:02 +0000 Original-Received: (at 64927) by debbugs.gnu.org; 3 Aug 2023 16:30:49 +0000 Original-Received: from localhost ([127.0.0.1]:52800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRbDs-0002KQ-W4 for submit@debbugs.gnu.org; Thu, 03 Aug 2023 12:30:49 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:59985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRbDr-0002KD-Ap for 64927@debbugs.gnu.org; Thu, 03 Aug 2023 12:30:47 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id BD46F44467B; Thu, 3 Aug 2023 12:30:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1691080240; bh=hecXTN/5NP2ARybgQjwMSYUmpTTKB7djUYX1wqs9VXI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=iKCzHz0WO/X1Z321saS0cpzf9n+PW/wmWMHiW+1y8TxHkMavbx6nj1mb7+XHMMDaH 36UR7GPUTHVTqwI7ylUXvlPWMKmnjEY9ePz/G/bcC+OUvb01japYIDo/reLSUeh/nl aYq9Lv6Kzl0P7vbwXHUJAmPNsSay5XCR6n+EC5A1cnIxJUAAQsVjFgCHwesKpNYpn+ qUCWbL07tHceAd4bBzuN2ZII2jwElAQ3UDZgb3gspdH9PvMrZtYatAuPt9SjCmsIQx ExfjtTyXCkXNhBOTHy77OLcDfh9AvR0xZwp4a3JhLeFDGAstVmYNpR9ofKKxE/a/py OzoWmfiWhJykA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3CEB0444678; Thu, 3 Aug 2023 12:30:40 -0400 (EDT) Original-Received: from alfajor (unknown [181.44.118.150]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 085FF1202E4; Thu, 3 Aug 2023 12:30:38 -0400 (EDT) In-Reply-To: <83y1isw1yl.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 03 Aug 2023 19:00:18 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266602 Archived-At: >> IOW, this is a fundamental incompatibility introduced by the support for >> this new [] format in `define-key`: keys cannot be arbitrary >> objects any more (among other things they can't be strings any more). > Hmm... that's bad, isn't it? Menus always supported strings like > that, so we have now lost that? Yes, tho admittedly such unconventional keys had various rough corners (e.g. they triggered a few bugs over the years). I think this problem was noticed when the new feature was introduced and we fixed the generation of the kill-ring menu, but apparently nobody fixed the problem in the second part of the code which generates the kill-ring (I remember I mentioned at the time that we should try and consolidate those two code paths). > Do you see any reasonably practical way to get that back? The best we can do is to use `key-valid-p` as a best-effort test to decide whether we're in the presence of the new or the old format, but it will inevitably suffer from false positives/negatives. Stefan