From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70357: 30.0.50; loadup.el, load nadvice before seq Date: Fri, 12 Apr 2024 16:43:56 -0400 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3011"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 70357@debbugs.gnu.org To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 12 22:45:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rvNlt-0000YD-Mc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Apr 2024 22:45:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rvNlY-00077N-Bb; Fri, 12 Apr 2024 16:44:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvNlV-00076k-MX for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2024 16:44:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rvNlU-0005gr-Hq for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2024 16:44:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rvNle-0006J2-DW for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2024 16:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Apr 2024 20:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70357 X-GNU-PR-Package: emacs Original-Received: via spool by 70357-submit@debbugs.gnu.org id=B70357.171295466223868 (code B ref 70357); Fri, 12 Apr 2024 20:45:02 +0000 Original-Received: (at 70357) by debbugs.gnu.org; 12 Apr 2024 20:44:22 +0000 Original-Received: from localhost ([127.0.0.1]:59674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvNkz-0006Ct-Ou for submit@debbugs.gnu.org; Fri, 12 Apr 2024 16:44:21 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:10990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvNkw-0006BA-Ac for 70357@debbugs.gnu.org; Fri, 12 Apr 2024 16:44:19 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 512D0442523; Fri, 12 Apr 2024 16:44:01 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1712954640; bh=jLUV4PIGMpsXIKF1jHNLK5Uj23opaFxYXvGaMf89gVc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=LHYIgrmf5tFnyQvFJv2w4HPmQt7IXiNLjxMDVIQbUpDwfSqpgDPyuXs1Wb82r63NS HyQRrdslEmKrpIRzQafPE1cKZ65nFDsRIWaL1Vt4ZPbPo7nVY07Y+ElrzWn5IVrOS4 LKsn3s9fSOueW8FzCkHQXcDvMMnH1LKjoojcwxqqVFsFre+80/sxpoMJm+SA0sWYRc n50dJNbCNJIRuaCXpWaH+vEtOV1nIqJISNVzNsAIDZN8UOpoNRUhRUDsOnwloDn/go 7xmLaGwQr83Tvb3XQTWe+Um+Zn8gPIiXa7RAjjPj6ti/0aNyjx0MGtj951Zf5gmu1z JPXo3AdTGflfg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id F19E844212D; Fri, 12 Apr 2024 16:43:59 -0400 (EDT) Original-Received: from alfajor (unknown [76.9.204.122]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D01001202D5; Fri, 12 Apr 2024 16:43:59 -0400 (EDT) In-Reply-To: ("Gerd =?UTF-8?Q?M=C3=B6llmann?="'s message of "Fri, 12 Apr 2024 20:19:40 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283149 Archived-At: > I would like to propose loading nadvice before seq in loadup.el, for the > following reason: I'm not opposed to reordering, but ... have you tried? AFAICT, `nadvice` requires `oclosure` which requires `cl-lib` which uses `seq`, so it might be tricky. > If a seq.elc exists, and we dump bootstrap-emacs.pdmp, and seq.el gets > loaded, then the cl-generic machinery will want to warn about the fact > that certain method stuff in seq.elc is already compiled. This warning > wants to use somethign from nadvice, and ultimately a recursive load > (warnings.el requires icons.el, which uses seq, which leads to a > warning, etc). As a general rule, it's better (long term) to try and fix those circular dependencies by breaking the cycle. Maybe we could tweak `cl-generic` so it calls the byte-compiler in a way that silences all the warnings? Also, I'm not sure loading `icons` is necessary batch mode, so maybe we could make that conditional. Stefan