From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects Date: Fri, 05 Jul 2024 00:24:55 -0400 Message-ID: References: <877ce17ncn.fsf@web.de> <87sewo5vym.fsf@web.de> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18352"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 71934-done@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 05 06:26:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPaWj-0004WD-2E for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jul 2024 06:26:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPaWH-00067f-74; Fri, 05 Jul 2024 00:26:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPaWG-00066B-0S for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 00:26:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPaWF-0005i3-Od for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 00:25:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPaWI-0003Um-6b for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 00:26:02 -0400 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jul 2024 04:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 71934 X-GNU-PR-Package: emacs Mail-Followup-To: 71934@debbugs.gnu.org, monnier@iro.umontreal.ca, michael_heerdegen@web.de Original-Received: via spool by 71934-done@debbugs.gnu.org id=D71934.172015352013371 (code D ref 71934); Fri, 05 Jul 2024 04:26:01 +0000 Original-Received: (at 71934-done) by debbugs.gnu.org; 5 Jul 2024 04:25:20 +0000 Original-Received: from localhost ([127.0.0.1]:43342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPaVb-0003Tb-Os for submit@debbugs.gnu.org; Fri, 05 Jul 2024 00:25:20 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPaVZ-0003TN-82 for 71934-done@debbugs.gnu.org; Fri, 05 Jul 2024 00:25:18 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8378610005D; Fri, 5 Jul 2024 00:25:06 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1720153505; bh=/t5s/OPX36rGb8txGetf5E7sO6HixInee4WOPE/5Zn0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Z1KtNWVbixRxrK6TzrhAeHU5jZ7dQZqu47TQLSeWutMwBboZRywN3bMak8o3EVxCP ZxjcjXRsBBcPscJw5NFhy1U55HdZN+CjBNgt6CBo7R0YaLlySFYQo1aSfW60tVHaA4 PbgDw2PIWp46+qy3RFETMAn23VhvZMVxkzGwTISfM+X2060mSWQrCZBT+MFOC3ISoL Gtwtujh6lu78MHlqmn+9Mz45Dpa9Hk8WfSWqtjf0lPW/dnZtWcB6t2KeSbw00Rz6c6 3oDJ9h/gDq0Jf4fVKAS9f/6xVwraOLTtUGPLaxx0xS4KSNonBWuEUUPgpkKmE2nt9n IWyMMX5eDIxWw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4540A100042; Fri, 5 Jul 2024 00:25:05 -0400 (EDT) Original-Received: from pastel (unknown [45.72.245.253]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 12591120478; Fri, 5 Jul 2024 00:25:05 -0400 (EDT) In-Reply-To: <87sewo5vym.fsf@web.de> (Michael Heerdegen's message of "Fri, 05 Jul 2024 06:00:49 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288403 Archived-At: >> I pushed a patch to `emacs-30` which should fix this. >> Can you confirm it fixes it in your real use case as well? > Thanks. Other use cases are fixed as well Thank you, closing. > but advices are broken :-( [...] > (advice-add 'f :around (defun my-f--around-ad (f &rest args) (apply f args))) AFAIK that's not new. > Hitting [print] says nil. AFAIU this should also work transparently, > right? The breakage seems to date further back in this case. It should work for most advices but not for `:around` advice, because fundamentally, it's virtually impossible to recognize this (apply f args) as being an "interactive call". > And i have another request: could you please search for the few other > occurrences of the symbol 'closure' in the Emacs Elisp code base? > I guess in most cases there is a need to update these places, too. I already did. There's one case on `comp.el` which may require some update, but I don't understand the code enough to know what it intends to do. It seems to match both `lambda` and `closure`, hence function *values*, but somehow it doesn't try and handle byte-code functions which are far more common function values, so maybe the `closure` is just irrelevant and the code is expected to match source code expressions (whose evaluation will return functions)? Stefan