all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 71934-done@debbugs.gnu.org
Subject: bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects
Date: Fri, 05 Jul 2024 00:24:55 -0400	[thread overview]
Message-ID: <jwva5iweatz.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87sewo5vym.fsf@web.de> (Michael Heerdegen's message of "Fri, 05 Jul 2024 06:00:49 +0200")

>> I pushed a patch to `emacs-30` which should fix this.
>> Can you confirm it fixes it in your real use case as well?
> Thanks.  Other use cases are fixed as well

Thank you, closing.

>  but advices are broken :-(
[...]
> (advice-add 'f :around (defun my-f--around-ad (f &rest args) (apply f args)))

AFAIK that's not new.

> Hitting [print] says nil.  AFAIU this should also work transparently,
> right?  The breakage seems to date further back in this case.

It should work for most advices but not for `:around` advice, because
fundamentally, it's virtually impossible to recognize this

    (apply f args)

as being an "interactive call".

> And i have another request: could you please search for the few other
> occurrences of the symbol 'closure' in the Emacs Elisp code base?
> I guess in most cases there is a need to update these places, too.

I already did.
There's one case on `comp.el` which may require some update, but I don't
understand the code enough to know what it intends to do.
It seems to match both `lambda` and `closure`, hence function *values*,
but somehow it doesn't try and handle byte-code functions which are far
more common function values, so maybe the `closure` is just irrelevant
and the code is expected to match source code expressions (whose
evaluation will return functions)?


        Stefan






  reply	other threads:[~2024-07-05  4:24 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-04  5:11 bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-04 13:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-04 15:47   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-05  4:00     ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-05  4:24       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-07-05  5:06         ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-05  5:48           ` Eli Zaretskii
2024-07-05  8:46             ` Andrea Corallo
     [not found]               ` <jwvtth4c7f3.fsf-monnier+emacs@gnu.org>
     [not found]                 ` <Zof2edaqLQfHD4_B@ACM>
     [not found]                   ` <jwvbk3b970b.fsf-monnier+emacs@gnu.org>
2024-07-05 16:48                     ` bug#71934: comp--spill-lap-function and closure (wad: bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects) Alan Mackenzie
2024-07-05 18:17                       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-05 19:55                         ` Alan Mackenzie
2024-07-05 20:26                           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-05 21:41                             ` Alan Mackenzie
2024-07-06  1:06                               ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-06  6:36                                 ` Eli Zaretskii
2024-07-06  8:06                                   ` Andrea Corallo
2024-07-06 14:27                                 ` Alan Mackenzie
2024-07-08  1:35                                   ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-08  2:32                                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-08  8:47                                       ` Andrea Corallo
2024-07-08 10:18                                     ` Alan Mackenzie
2024-07-09  5:19                                       ` bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-06  7:48                           ` bug#71934: comp--spill-lap-function and closure (wad: bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects) Andrea Corallo
2024-07-06 11:01                             ` Alan Mackenzie
2024-07-06 17:29                               ` Andrea Corallo
2024-07-09 20:49                                 ` Andrea Corallo
2024-07-10 10:29                                   ` Alan Mackenzie
2024-07-10 11:28                                     ` Andrea Corallo
2024-07-06  7:33                       ` Andrea Corallo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwva5iweatz.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=71934-done@debbugs.gnu.org \
    --cc=michael_heerdegen@web.de \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.