From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: undo weirdness with insert-file-contents Date: Thu, 28 Feb 2008 11:52:53 -0500 Message-ID: References: <47C6856B.7080405@gmx.at> <47C6B359.10302@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1204217607 11477 80.91.229.12 (28 Feb 2008 16:53:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Feb 2008 16:53:27 +0000 (UTC) Cc: emacs-devel@gnu.org, Miles Bader To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 28 17:53:50 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JUm0y-0002wT-OV for ged-emacs-devel@m.gmane.org; Thu, 28 Feb 2008 17:53:49 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUm0S-0005Jp-Cr for ged-emacs-devel@m.gmane.org; Thu, 28 Feb 2008 11:53:16 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JUm0N-0005JA-F9 for emacs-devel@gnu.org; Thu, 28 Feb 2008 11:53:11 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JUm0J-0005IA-O4 for emacs-devel@gnu.org; Thu, 28 Feb 2008 11:53:10 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUm0J-0005I6-Jn for emacs-devel@gnu.org; Thu, 28 Feb 2008 11:53:07 -0500 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JUm0F-0001F1-SV; Thu, 28 Feb 2008 11:53:03 -0500 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 8D8F52CF92A; Thu, 28 Feb 2008 11:53:03 -0500 (EST) Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 3FBA93FE0; Thu, 28 Feb 2008 11:52:53 -0500 (EST) Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 1E2BA6CAAA; Thu, 28 Feb 2008 11:52:53 -0500 (EST) In-Reply-To: <47C6B359.10302@gmx.at> (martin rudalics's message of "Thu, 28 Feb 2008 14:12:57 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:90735 Archived-At: > The (1 . 21) entry is silly and obviously breaks undoing the prior > (insert "Foo: bar\n"). Although EQ (XCAR (tem), lbeg) was not very > intelligent, setting this to (XCAR (tem) == lbeg) doesn't seem to help > either. Please try again with the attached patch. I recommend you compile your Emacs with -DUSE_LISP_UNION_TYPE so the compiler will explain to you where you're going wrong: XCAR (tem) is a Lisp_Object, not an integer, so it cannot be compared with ==, but only with EQ (which doesn't strike me as particularly non-intelligent in this instance). Stefan