From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: patch to hilight-chg not in emacs 22.1 Date: Mon, 17 Mar 2008 10:11:18 -0400 Message-ID: References: <7C11E945-3ED3-45A0-A3D2-1F700D12BC9B@pobox.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1205763113 9920 80.91.229.12 (17 Mar 2008 14:11:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Mar 2008 14:11:53 +0000 (UTC) Cc: Juanma Barranquero , martin rudalics , Richard Stallman , Emacs Devel To: Richard Sharman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 17 15:12:18 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JbG4O-0001yX-2e for ged-emacs-devel@m.gmane.org; Mon, 17 Mar 2008 15:12:08 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JbG3o-0002HT-5Q for ged-emacs-devel@m.gmane.org; Mon, 17 Mar 2008 10:11:32 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JbG3j-0002GH-Lc for emacs-devel@gnu.org; Mon, 17 Mar 2008 10:11:27 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JbG3g-0002Ek-Pz for emacs-devel@gnu.org; Mon, 17 Mar 2008 10:11:26 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JbG3g-0002ET-8X for emacs-devel@gnu.org; Mon, 17 Mar 2008 10:11:24 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JbG3c-00010W-6o; Mon, 17 Mar 2008 10:11:20 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAEsZ3kdMCrTo/2dsb2JhbACnPIEK X-IronPort-AV: E=Sophos;i="4.25,512,1199682000"; d="scan'208";a="16138763" Original-Received: from smtp.pppoe.ca ([65.39.196.238]) by ironport2-out.pppoe.ca with ESMTP; 17 Mar 2008 10:11:18 -0400 Original-Received: from pastel.home ([76.10.180.232]) by smtp.pppoe.ca (Internet Mail Server v1.0) with ESMTP id XRC74718; Mon, 17 Mar 2008 10:11:18 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 672A57F1C; Mon, 17 Mar 2008 10:11:18 -0400 (EDT) In-Reply-To: <7C11E945-3ED3-45A0-A3D2-1F700D12BC9B@pobox.com> (Richard Sharman's message of "Sun, 16 Mar 2008 13:52:49 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:92830 Archived-At: > So, I have simplified the change to hilit-chg.el and have removed the part > that required the change to easy-mmode. (I think what I was previously > doing was overkill anyway.) Thank you, this looks good. I'd only advise you to rename highlight-changes-toggle-visibility to highlight-changes-visible-mode and define it (yet again) with define-minor-mode. > I will attach here this new patch (against 22.1). Could you make a new patch against the trunk (your patch did not apply there, so it looks like there's been some changes, probably minor). > Note: I have not addressed the problem mentioned by Stefan and Martin, > since it seems as if they have already handled it. I do not remember what those problems were. Could you refresh my memory? Stefan