all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Richard Sharman <rsharman@pobox.com>
Cc: Juanma Barranquero <lekktu@gmail.com>,
	martin rudalics <rudalics@gmx.at>, Richard Stallman <rms@gnu.org>,
	Emacs Devel <emacs-devel@gnu.org>
Subject: Re: patch to hilight-chg not in emacs 22.1
Date: Mon, 17 Mar 2008 10:11:18 -0400	[thread overview]
Message-ID: <jwv8x0ha1i8.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <7C11E945-3ED3-45A0-A3D2-1F700D12BC9B@pobox.com> (Richard Sharman's message of "Sun, 16 Mar 2008 13:52:49 -0400")

> So,  I have simplified the change to hilit-chg.el and have removed the part
> that required the change to easy-mmode.  (I think what I was  previously
> doing was overkill anyway.)

Thank you, this looks good.  I'd only advise you to rename
highlight-changes-toggle-visibility to highlight-changes-visible-mode
and define it (yet again) with define-minor-mode.

> I will attach here this new patch (against 22.1).

Could you make a new patch against the trunk (your patch did not apply
there, so it looks like there's been some changes, probably minor).

> Note:  I have not addressed the problem mentioned by Stefan and Martin,
> since it seems as if they have already handled it.

I do not remember what those problems were.  Could you refresh my memory?


        Stefan




  reply	other threads:[~2008-03-17 14:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-16 17:52 patch to hilight-chg not in emacs 22.1 Richard Sharman
2008-03-17 14:11 ` Stefan Monnier [this message]
2008-03-18  3:11   ` Richard Sharman
2008-03-18 16:51     ` Stefan Monnier
2008-03-19  2:43       ` Richard Sharman
2008-03-19 16:20         ` Stefan Monnier
2008-04-25 14:27           ` Juanma Barranquero
2008-05-02  3:21             ` Richard Sharman
2008-05-02  8:53               ` Juanma Barranquero
2008-03-18  9:55 ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv8x0ha1i8.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=lekktu@gmail.com \
    --cc=rms@gnu.org \
    --cc=rsharman@pobox.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.