From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: NeXTstep (GNUstep/Cocoa) port and merging Date: Tue, 03 Jun 2008 22:34:20 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1212546892 20882 80.91.229.12 (4 Jun 2008 02:34:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Jun 2008 02:34:52 +0000 (UTC) Cc: emacs-devel To: Adrian Robert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 04 04:35:34 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K3iqU-0002PK-P1 for ged-emacs-devel@m.gmane.org; Wed, 04 Jun 2008 04:35:27 +0200 Original-Received: from localhost ([127.0.0.1]:35767 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3ipi-0001A5-Gq for ged-emacs-devel@m.gmane.org; Tue, 03 Jun 2008 22:34:38 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K3ipe-00018w-F1 for emacs-devel@gnu.org; Tue, 03 Jun 2008 22:34:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K3ipd-00018k-9V for emacs-devel@gnu.org; Tue, 03 Jun 2008 22:34:33 -0400 Original-Received: from [199.232.76.173] (port=50515 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3ipd-00018h-34 for emacs-devel@gnu.org; Tue, 03 Jun 2008 22:34:33 -0400 Original-Received: from 206-248-132-168.dsl.teksavvy.com ([206.248.132.168]:60513 helo=ceviche.home) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K3ipc-0001UQ-7o for emacs-devel@gnu.org; Tue, 03 Jun 2008 22:34:32 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id D2333B423C; Tue, 3 Jun 2008 22:34:20 -0400 (EDT) In-Reply-To: (Adrian Robert's message of "Tue, 3 Jun 2008 21:44:50 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:98349 Archived-At: > One area it would be nice to have some feedback on is the added file > "nsmenu_common.c". This file of about 1000 lines contains code that is > more or less duplicated (modulo some divergence) across {x,w32,mac}menu.c, > and is concerned mainly with mediating between lisp and C representations > of menus. I followed xmenu.c when creating the common file. It would be > good to change this to "menu_common.c" and have the other GUIs use it. Yes, it would indeed be good. I've already several times intended to make a similar change but never got around to really do it. If someone could take this part of the Emacs.app patch and make it independent from Emacs.app, that would be great. Stefan