From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#407: gpm server stop making emacs abort() Date: Fri, 13 Jun 2008 18:18:32 -0400 Message-ID: References: <87wsktf41m.fsf@blah.blah> Reply-To: Stefan Monnier , 407@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1213396045 32530 80.91.229.12 (13 Jun 2008 22:27:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Jun 2008 22:27:25 +0000 (UTC) To: 407@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 14 00:28:08 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K7Hkd-0000Om-Eq for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Jun 2008 00:28:07 +0200 Original-Received: from localhost ([127.0.0.1]:34994 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7Hjp-0002ff-K5 for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jun 2008 18:27:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K7Hjk-0002fQ-Hg for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2008 18:27:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K7Hji-0002f2-5q for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2008 18:27:11 -0400 Original-Received: from [199.232.76.173] (port=34706 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7Hjh-0002ez-Tz for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2008 18:27:09 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:41972) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K7Hjh-0006bw-N3 for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2008 18:27:09 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m5DMR70E010658; Fri, 13 Jun 2008 15:27:07 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m5DMP45A009533; Fri, 13 Jun 2008 15:25:04 -0700 X-Loop: don@donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 13 Jun 2008 22:25:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 407 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 407-submit@emacsbugs.donarmstrong.com id=B407.12133955578286 (code B ref 407); Fri, 13 Jun 2008 22:25:04 +0000 Original-Received: (at 407) by emacsbugs.donarmstrong.com; 13 Jun 2008 22:19:17 +0000 Original-Received: from chene.dit.umontreal.ca (chene.dit.umontreal.ca [132.204.246.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m5DMJDVM008280 for <407@emacsbugs.donarmstrong.com>; Fri, 13 Jun 2008 15:19:15 -0700 Original-Received: from ceviche.home (vpn-132-204-232-72.acd.umontreal.ca [132.204.232.72]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id m5DMJB9n005652 for <407@emacsbugs.donarmstrong.com>; Fri, 13 Jun 2008 18:19:13 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id DBA55B4087; Fri, 13 Jun 2008 18:18:32 -0400 (EDT) In-Reply-To: <87wsktf41m.fsf@blah.blah> (Kevin Ryde's message of "Sat, 14 Jun 2008 06:55:33 +1000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered HAS_X_HELO=0, RV3038=0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Fri, 13 Jun 2008 18:27:11 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:18371 Archived-At: > If running with > (gpm-mouse-mode 1) > and if you stop the gpm server, then emacs dies with > Fatal error (6)Aborted > Output from "bt full" below; xbacktrace printed nothing at all. > The backtrace shows it at the abort() under the EBADF case in > wait_reading_process_output(). I think when Gpm_GetEvent gets an eof > from the server it closes gpm_fd; maybe that's the bad fd in question. I can't test it right now. Does the patch below help? Stefan --- keyboard.c.~1.959.~ 2008-06-03 02:14:30.000000000 -0400 +++ keyboard.c 2008-06-13 18:17:35.000000000 -0400 @@ -7189,6 +7189,8 @@ while (gpm = Gpm_GetEvent (&event), gpm == 1) { nread += handle_one_term_event (tty, &event, &hold_quit); } + if (gpm < 0) + delete_gpm_wait_descriptor (gpm_fd); if (hold_quit.kind != NO_EVENT) kbd_buffer_store_event (&hold_quit); if (nread)