all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: 407@emacsbugs.donarmstrong.com
Subject: bug#407: gpm server stop making emacs abort()
Date: Fri, 13 Jun 2008 18:18:32 -0400	[thread overview]
Message-ID: <jwv8wx99dyr.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <87wsktf41m.fsf@blah.blah> (Kevin Ryde's message of "Sat, 14 Jun 2008 06:55:33 +1000")

> If running with
> 	(gpm-mouse-mode 1)
> and if you stop the gpm server, then emacs dies with
> 	Fatal error (6)Aborted
> Output from "bt full" below; xbacktrace printed nothing at all.

> The backtrace shows it at the abort() under the EBADF case in
> wait_reading_process_output().  I think when Gpm_GetEvent gets an eof
> from the server it closes gpm_fd; maybe that's the bad fd in question.

I can't test it right now.  Does the patch below help?


        Stefan


--- keyboard.c.~1.959.~	2008-06-03 02:14:30.000000000 -0400
+++ keyboard.c	2008-06-13 18:17:35.000000000 -0400
@@ -7189,6 +7189,8 @@
       while (gpm = Gpm_GetEvent (&event), gpm == 1) {
 	  nread += handle_one_term_event (tty, &event, &hold_quit);
       }
+      if (gpm < 0)
+	delete_gpm_wait_descriptor (gpm_fd);
       if (hold_quit.kind != NO_EVENT)
 	  kbd_buffer_store_event (&hold_quit);
       if (nread)






  reply	other threads:[~2008-06-13 22:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <jwvocvndjs1.fsf-monnier+emacsbugreports@gnu.org>
2008-06-13 20:55 ` bug#407: gpm server stop making emacs abort() Kevin Ryde
2008-06-13 22:18   ` Stefan Monnier [this message]
     [not found]   ` <mailman.13216.1213396033.18990.bug-gnu-emacs@gnu.org>
2008-07-01 20:43     ` Sven Joachim
2008-07-03 22:00       ` Kevin Ryde
2008-09-12  4:14       ` Stefan Monnier
2008-09-12  5:54         ` Sven Joachim
2008-09-12 17:08           ` Stefan Monnier
2008-10-30 22:11             ` Kevin Ryde
2009-03-27 16:25   ` bug#407: marked as done (gpm server stop making emacs abort()) Emacs bug Tracking System
     [not found]   ` <handler.407.D407.123817070925838.notifdone@emacsbugs.donarmstrong.com>
2009-03-28  0:46     ` bug#407: closed by Stefan Monnier <monnier@iro.umontreal.ca> " Kevin Ryde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv8wx99dyr.fsf-monnier+emacsbugreports@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=407@emacsbugs.donarmstrong.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.