From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: vc-git bug with top-level repositories Date: Wed, 27 Aug 2008 22:09:21 -0400 Message-ID: References: <200808181433.m7IEX8U3028640@sallyv1.ics.uci.edu> <200808181639.m7IGd1kb005968@sallyv1.ics.uci.edu> <200808182031.m7IKVbR7001754@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1219889387 12166 80.91.229.12 (28 Aug 2008 02:09:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Aug 2008 02:09:47 +0000 (UTC) Cc: claus.klingberg@gmail.com, eliz@gnu.org, dann@ics.uci.edu, emacs-devel@gnu.org To: ams@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 28 04:10:40 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KYWy7-0001D0-5y for ged-emacs-devel@m.gmane.org; Thu, 28 Aug 2008 04:10:39 +0200 Original-Received: from localhost ([127.0.0.1]:45715 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYWx8-0006j3-Pr for ged-emacs-devel@m.gmane.org; Wed, 27 Aug 2008 22:09:38 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYWx4-0006if-JJ for emacs-devel@gnu.org; Wed, 27 Aug 2008 22:09:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYWx3-0006iL-48 for emacs-devel@gnu.org; Wed, 27 Aug 2008 22:09:34 -0400 Original-Received: from [199.232.76.173] (port=34305 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYWx3-0006iI-1y for emacs-devel@gnu.org; Wed, 27 Aug 2008 22:09:33 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:26742 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KYWws-0002tv-Qi; Wed, 27 Aug 2008 22:09:22 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AsIEAGCltUhFxI/k/2dsb2JhbACBZbgRgWiBBw X-IronPort-AV: E=Sophos;i="4.32,283,1217822400"; d="scan'208";a="26063147" Original-Received: from 69-196-143-228.dsl.teksavvy.com (HELO pastel.home) ([69.196.143.228]) by ironport2-out.teksavvy.com with ESMTP; 27 Aug 2008 22:09:22 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 452257F01; Wed, 27 Aug 2008 22:09:21 -0400 (EDT) In-Reply-To: (Alfred M. Szmidt's message of "Wed, 27 Aug 2008 17:17:19 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:103066 Archived-At: >> How about adding an extra check, where we check the write permissions >> as well for the user and group? That is, if the user and the group >> the user is member of, cannot write to the .git directory then we stop >> traversing... > I don't think this will fly: currently VC works even when you're looking > at a project to which you don't have write access, so neither the files > nor the .git might be writable. > AFAIK, atleast for git, you must have write access, if you do not you > cannot ceate a lock file. So you need write access even just to do things like diff or even just diff-index? That's too bad. So maybe for Git we could use that refinement of my heuristic, but it wouldn't help for other backends. Stefan