From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#810: 23.0.60; atomic-change-group narrowing problem Date: Mon, 01 Sep 2008 22:38:48 -0400 Message-ID: References: <48B6F562.9060006@gmail.com> <48BC2CE6.2070108@gmx.at> <48BC5C9D.9000008@gmx.at> <48BC6442.2060608@gmail.com> Reply-To: Stefan Monnier , 810@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1220323675 30269 80.91.229.12 (2 Sep 2008 02:47:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 2 Sep 2008 02:47:55 +0000 (UTC) Cc: 810@emacsbugs.donarmstrong.com To: "Lennart Borgman \(gmail\)" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 02 04:48:50 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KaLwn-0001fP-25 for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Sep 2008 04:48:49 +0200 Original-Received: from localhost ([127.0.0.1]:42221 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KaLvj-0003NX-Mx for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Sep 2008 22:47:43 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KaLvf-0003Mv-Dn for bug-gnu-emacs@gnu.org; Mon, 01 Sep 2008 22:47:39 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KaLvd-0003Lz-Tf for bug-gnu-emacs@gnu.org; Mon, 01 Sep 2008 22:47:39 -0400 Original-Received: from [199.232.76.173] (port=33172 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KaLvd-0003Lw-Pu for bug-gnu-emacs@gnu.org; Mon, 01 Sep 2008 22:47:37 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:60267) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KaLvc-0006pH-Q4 for bug-gnu-emacs@gnu.org; Mon, 01 Sep 2008 22:47:37 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m822lUf8001877; Mon, 1 Sep 2008 19:47:31 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m822j7nv000713; Mon, 1 Sep 2008 19:45:07 -0700 X-Loop: don@donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 02 Sep 2008 02:45:07 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 810 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 810-submit@emacsbugs.donarmstrong.com id=B810.122032313831081 (code B ref 810); Tue, 02 Sep 2008 02:45:07 +0000 Original-Received: (at 810) by emacsbugs.donarmstrong.com; 2 Sep 2008 02:38:58 +0000 Original-Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m822ct4S031075 for <810@emacsbugs.donarmstrong.com>; Mon, 1 Sep 2008 19:38:56 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AuYEAF9EvEhFxJrH/2dsb2JhbACBZbEWgWmBBw X-IronPort-AV: E=Sophos;i="4.32,312,1217822400"; d="scan'208";a="26207185" Original-Received: from 69-196-154-199.dsl.teksavvy.com (HELO pastel.home) ([69.196.154.199]) by ironport2-out.teksavvy.com with ESMTP; 01 Sep 2008 22:38:50 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id ADD247FF1; Mon, 1 Sep 2008 22:38:48 -0400 (EDT) In-Reply-To: <48BC6442.2060608@gmail.com> (Lennart Borgman's message of "Mon, 01 Sep 2008 23:53:06 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Mon, 01 Sep 2008 22:47:39 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:20006 Archived-At: >>>>> When using atomic-change-group I got the message >>>>> undo-more: Changes to be undone are outside visible portion of buffer >>>>> The changes are also not undone. This seems wrong to me. >>> >>>> The attached patch now also tries to restore any narrowing in force >>>> before the atomic change. >>> >>> I'm not sure we should do that. Currently, narrowing operations are not >>> saved to the undo-log, so making atomic-change-group save&restore the >>> narrowing makes it behave differently from the undo. >> >> I know what you mean but the present case is different. When someone >> uses narrowing within the atomic change group and we really want to undo >> the changes (we still can decide that we won't fix the bug ;-)) we have >> to widen the buffer. If the buffer was narrowed _before_ entering the >> atomic change group, it would be incorrect not to restore that. Or am I >> missing something? The widening needs to be temporary around the call to undo, but that doesn't seem to imply that atomic-change-group will preserve narrowing. Stefan