From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99848: (compilation-save-buffers-predicate): Date: Mon, 12 Apr 2010 17:15:40 -0400 Message-ID: References: <4BBF536E.4090702@gnu.org> <87r5ml3icx.fsf@gnu.org> <4BC37C58.1030306@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1271107626 20601 80.91.229.12 (12 Apr 2010 21:27:06 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 12 Apr 2010 21:27:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: Sam Steingold Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 12 23:27:04 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O1R9r-0001JL-Kc for ged-emacs-devel@m.gmane.org; Mon, 12 Apr 2010 23:27:03 +0200 Original-Received: from localhost ([127.0.0.1]:34991 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O1QzM-0006SV-8a for ged-emacs-devel@m.gmane.org; Mon, 12 Apr 2010 17:16:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O1Qyv-0006Is-5d for emacs-devel@gnu.org; Mon, 12 Apr 2010 17:15:45 -0400 Original-Received: from [140.186.70.92] (port=59187 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O1Qyt-0006I4-P0 for emacs-devel@gnu.org; Mon, 12 Apr 2010 17:15:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O1Qyr-0008W2-SF for emacs-devel@gnu.org; Mon, 12 Apr 2010 17:15:43 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183]:10333 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O1Qyr-0008Vu-Q8; Mon, 12 Apr 2010 17:15:41 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAKsqw0tMCqWu/2dsb2JhbACbOnK9FYUMBItG X-IronPort-AV: E=Sophos;i="4.52,192,1270440000"; d="scan'208";a="60708354" Original-Received: from 76-10-165-174.dsl.teksavvy.com (HELO pastel.home) ([76.10.165.174]) by ironport2-out.pppoe.ca with ESMTP; 12 Apr 2010 17:15:40 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id DE4107F1B; Mon, 12 Apr 2010 17:15:40 -0400 (EDT) In-Reply-To: <4BC37C58.1030306@gnu.org> (Sam Steingold's message of "Mon, 12 Apr 2010 16:02:32 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:123545 Archived-At: >> Introducing `compile-default-directory' is not the end of the world, but >> to my naive eyes, if `default-directory' doesn't point to the right >> place, it's a bug to be fixed. > default-directory "Automatically becomes buffer-local when set in any > fashion" this means that it is useless in > compilation-save-buffers-predicate because that is called inside the > buffer to be saved and thus for it default-directory should be the > directory where the buffer is located. Ah, yes, that would be a good reason, sorry for being so dense. >>>> How 'bout this: >>>> - we provide some way for the user to explain to compile.el how to find >>>> her projects's root directories (e.g. a list of tell-tale file names). >>> this is tricky: some files might be ordinary for some projects and the >>> tell-tale for others. >> I know, that's a significant problem, but I can't think of a really good >> solution other than push it onto the user by providing a customizable >> variable. My main goal here is to make sure that we can support the >> case where the user has several projects, which seems like a common >> enough case, especially for Free Software hackers. > I think this variable should be buffer-local (with an eye on being set in > dir_locals). Ah! Thanks for finally answering my original question "Could you explain how you see it being used?" ;-) My first answer would have been: in that case it probably shouldn't be a defcustom. But by now, I think we *can* give it a good global default value (and justify it being a defcustom). This default value will depend on Emacs being able to figure out what is "the current project", which is something where Emacs needs to improve anyway, so it's a good direction. >>>> - and we can also provide an option to "cd to project's root before >>>> running the command". >>> I doubt the value of this. >> I've used several build systems where this is necessary (e.g. a single >> Makefile at the root, or something equivalent). I usually work around >> it with something like M-x compile RET cd ..; make RET, but if `compile' >> could insert the "cd .." for me when needed it would be even better. > this sounds like a case for yet another buffer-local variable - > build-directory Could be. In my case this build-dir has always been the same as the project's root, but indeed there may be cases where something else is needed. We'll cross that bridge when we get there. Stefan