From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: The unwarranted scrolling assumption Date: Fri, 18 Jun 2010 11:22:43 -0400 Message-ID: References: <87631jvpzg.fsf@gmail.com> <4C18211C.3070106@harpegolden.net> <87vd9j5neu.fsf@kfs-lx.rd.rdm> <83sk4misf2.fsf@gnu.org> <83iq5hiiin.fsf@gnu.org> <83fx0lihov.fsf@gnu.org> <83aaqsiyb6.fsf@gnu.org> <83zkysh2hb.fsf@gnu.org> <83vd9gh0s6.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1276874915 29943 80.91.229.12 (18 Jun 2010 15:28:35 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 18 Jun 2010 15:28:35 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Lennart Borgman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 18 17:28:33 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OPdUe-0002am-J0 for ged-emacs-devel@m.gmane.org; Fri, 18 Jun 2010 17:28:32 +0200 Original-Received: from localhost ([127.0.0.1]:49085 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPdUd-00034Y-NE for ged-emacs-devel@m.gmane.org; Fri, 18 Jun 2010 11:28:31 -0400 Original-Received: from [140.186.70.92] (port=48649 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPdP6-00067i-7y for emacs-devel@gnu.org; Fri, 18 Jun 2010 11:22:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OPdP4-0001nk-Oh for emacs-devel@gnu.org; Fri, 18 Jun 2010 11:22:48 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183]:16776 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPdP2-0001mz-ME; Fri, 18 Jun 2010 11:22:44 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEADksG0xLd+Hj/2dsb2JhbACfEHLCSYUbBI0Y X-IronPort-AV: E=Sophos;i="4.53,440,1272859200"; d="scan'208";a="68356516" Original-Received: from 75-119-225-227.dsl.teksavvy.com (HELO pastel.home) ([75.119.225.227]) by ironport2-out.pppoe.ca with ESMTP; 18 Jun 2010 11:22:43 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 9B1E97F26; Fri, 18 Jun 2010 11:22:43 -0400 (EDT) In-Reply-To: (Lennart Borgman's message of "Fri, 18 Jun 2010 16:37:55 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126176 Archived-At: >> I already did, and I think that code is correct. =A0Obviously, >> clip_changed needs to be set whenever the narrowing changes. > Ah, finally. Good. > And why do you think that? because src/buffer.h says: /* Set nonzero whenever the narrowing is changed in this buffer. */ int clip_changed; "clipping" and "narrowing" are the same thing. So, changing the narrowing should say that clipping has changed. All it says is "narrowing has been changed at some point, don't forget to check it". So it's the redisplay's responsability to determine whether narrowing is indeed different from what it was during the last redisplay (and clip_changed is just a variable that can save us from performing this check). If setting clip_changed to 1 in the main loop has some other effect than slowing things down, that means we have a bug in redisplay. Stefan