From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: "Herbert J. Skuhra" <h.skuhra@gmail.com>, 7693@debbugs.gnu.org
Subject: bug#7693: 24.0.50, 23.2.91; advice to kill-new causes warning
Date: Thu, 23 Dec 2010 10:37:38 -0500 [thread overview]
Message-ID: <jwv8vzgmroz.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <b4mr5dc6jkg.fsf@jpl.org> (Katsumi Yamaoka's message of "Tue, 21 Dec 2010 09:44:31 +0900")
severity 7693 minor
thanks
> Maybe it's harmless but surprises me a bit.
Indeed, it's harmless, and it's admittedly unjustified.
> (require 'bytecomp)
> (defadvice kill-new (before nop activate))
> This causes a warning in the "*Compile-Log*" buffer as follows:
> Warning: ad-Orig-kill-new called with 3 arguments, but accepts only 1-2
> It is because the arglist of `kill-new' is still
> (string &optional replace yank-handler), that `advice' recognizes
> by using `symbol-function'. Any idea?
I think it's right for the advice to use the obsolete (string &optional
replace yank-handler) rather than the advertised arglist, so what we'd
need to do here is just silence the warning (rather than change the code
generated by defadvice).
We already have a few other cases where we emit warnings for obsolete
vars and functions that aren't justified (typically in the code that
implements those obsolete objects). It would be good to figure out how
to cleanly silence such warnings.
Stefan
next prev parent reply other threads:[~2010-12-23 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 0:44 bug#7693: 24.0.50, 23.2.91; advice to kill-new causes warning Katsumi Yamaoka
2010-12-23 15:37 ` Stefan Monnier [this message]
2017-10-14 6:30 ` Noam Postavsky
2017-10-15 23:42 ` Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv8vzgmroz.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=7693@debbugs.gnu.org \
--cc=h.skuhra@gmail.com \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.